Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds recovery path for may payout problem (uplift to 1.8.x) #5518

Merged
merged 1 commit into from
May 12, 2020
Merged

Adds recovery path for may payout problem (uplift to 1.8.x) #5518

merged 1 commit into from
May 12, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented May 11, 2020 •
edited by kjozwiak
Loading

Uplift of #5495
Fixes brave/brave-browser#9684

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@NejcZdovc NejcZdovc requested a review from a team May 11, 2020 21:08
@NejcZdovc NejcZdovc requested a review from gdregalo as a code owner May 11, 2020 21:08
@NejcZdovc NejcZdovc self-assigned this May 11, 2020
@NejcZdovc NejcZdovc removed the request for review from gdregalo May 11, 2020 21:08
@kjozwiak
Copy link
Member

Travis also failed due to TEST_SUITE=test-security because of the yargs-parser npm package which is a known issue and not blocking uplift.

@bsclifton bsclifton added this to the 1.8.x - HF 3 Placeholder milestone May 12, 2020
kjozwiak
kjozwiak approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.8.x approved after deliberating with @brave/uplift-approvers. QA verified the PR on Nightly as per #5495 (comment). Ensured that the issue was moved into the appropriate milestone.

@kjozwiak kjozwiak merged commit 6ef85e3 into 1.8.x May 12, 2020
@kjozwiak kjozwiak deleted the recover-payout-1.8 branch May 12, 2020 07:06
@kjozwiak kjozwiak mentioned this pull request May 12, 2020
Closed
bsclifton pushed a commit that referenced this pull request May 12, 2020
@kjozwiak @bsclifton
Merge pull request #5518 from brave/recover-payout-1.8
f574085 
Adds recovery path for may payout problem (uplift to 1.8.x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards
Projects
None yet
Milestone
1.8.x - Release Hotfix 3
Development

Successfully merging this pull request may close these issues.
3 participants
@NejcZdovc @kjozwiak @bsclifton