Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows both memo and address for applicable assets [Binance] #5465

Merged
merged 1 commit into from
May 6, 2020
Merged

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented May 6, 2020

Fixes brave/brave-browser#9605

Screen Shot 2020-05-05 at 5 28 14 PM

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 1.10.x - Nightly milestone May 6, 2020
@ryanml ryanml requested a review from bbondy May 6, 2020 00:40
@ryanml ryanml self-assigned this May 6, 2020
{`${currentDepositAsset}`}
</DetailLabel>
<DetailInfo>
{getLocale('binanceWidgetAddressUnavailable')}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

= Info Not Available

@ryanml
Copy link
Contributor Author

ryanml commented May 6, 2020

Failure unrelated, builds generated

@ryanml ryanml merged commit ae4164e into master May 6, 2020
@ryanml ryanml deleted the fix-9605 branch May 6, 2020 14:54
ryanml added a commit that referenced this pull request May 6, 2020
Shows both memo and address for applicable assets [Binance]
ryanml added a commit that referenced this pull request May 6, 2020
Shows both memo and address for applicable assets [Binance]
@kjozwiak
Copy link
Member

kjozwiak commented May 7, 2020

Verification PASSED on macOS 10.15.4 x64 using the following build:

Brave | 1.10.36 Chromium: 81.0.4044.138 (Official Build) nightly (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.15.4 (Build 19E287)
  • ensured the following after upgrading 1.10.30 CR: 81.0.4044.129 --> 1.10.36
    • ensured that I was still connected to Binance after upgrading
    • ensured that both EOS Deposit Address & EOS Deposit Memo are being displayed via the widget under NTP
    • ensured that both EOS Deposit Address & EOS Deposit Memo are using the same addresses on the widget/binance website (making sure there's no discrepancies)
    • ensured that the Copy buttons and QR Code buttons are working as expected
    • ensured other addresses like BTC/BAT/ETH are being displayed
      • ensured that the Copy and QR Code buttons are working

Also went through the above cases on a clean install of 1.10.36 CR: 81.0.4044.138.

Screen Shot 2020-05-06 at 7 55 58 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Both address and Memo ID should be shown for supported coins
3 participants