Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher list improvements (uplift to 1.7.x) #5322

Merged
merged 3 commits into from
Apr 24, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 22, 2020

Uplift of #5301
Uplift of #5355
Uplift of #5356

Fixes brave/brave-browser#9376
Fixes brave/brave-browser#9440
Fixes brave/brave-browser#9441

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@NejcZdovc NejcZdovc requested a review from a team April 22, 2020 20:40
@NejcZdovc NejcZdovc self-assigned this Apr 22, 2020
@NejcZdovc NejcZdovc force-pushed the pr5301_publisher-list-improvments_1.7.x branch from 1f551fc to 7c87155 Compare April 22, 2020 20:43
@kjozwiak
Copy link
Member

Restarting Android as dist failed due to the node disconnecting as per https://ci.brave.com/job/brave-browser-build-pr/job/pr5301_publisher-list-improvments_1.7.x/1/execution/node/538/log

17:41:22  Cannot contact i-0d44ce7f07e22a3b8: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@391dbf1d:i-0d44ce7f07e22a3b8": Remote call on i-0d44ce7f07e22a3b8 failed. The channel is closing down or has closed down
17:46:27  Could not connect to i-0d44ce7f07e22a3b8 to send interrupt signal to process

Restarting Linux as dist failed due to the node disconnecting as per https://ci.brave.com/job/brave-browser-build-pr/job/pr5301_publisher-list-improvments_1.7.x/1/execution/node/566/log/:

17:57:56  Cannot contact linux-spot-6: hudson.remoting.ChannelClosedException: Channel "hudson.remoting.Channel@51ac58d:linux-spot-6": Remote call on linux-spot-6 failed. The channel is closing down or has closed down
18:05:47  ninja: build stopped: interrupted by user.
18:10:54  wrapper script does not seem to be touching the log file in /home/ubuntu/jenkins/workspace/publisher-list-improvments_1.7.x@tmp/durable-5bf07ee8
18:10:54  (JENKINS-48300: if on an extremely laggy filesystem, consider -Dorg.jenkinsci.plugins.durabletask.BourneShellScript.HEARTBEAT_CHECK_INTERVAL=86400)

Restarting Win x64 due to init failing as per https://ci.brave.com/job/brave-browser-build-pr/job/pr5301_publisher-list-improvments_1.7.x/1/execution/node/205/log/.

@kjozwiak kjozwiak added CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-android Do not run CI builds for Android CI/skip-linux labels Apr 22, 2020
@kjozwiak
Copy link
Member

Restarting Win x64 as it looks like init failed as per https://ci.brave.com/job/brave-browser-build-pr/job/pr5301_publisher-list-improvments_1.7.x/2/execution/node/307/log/

19:42:05  Warning: Running gclient on Python 3. 
19:42:05  If you encounter any issues, please file a bug on crbug.com under the Infra>SDK component.
19:42:05  
19:42:05  
19:42:05  WARNING: Your metrics.cfg file was invalid or nonexistent. A new one will be created.
19:42:05  
19:42:05  
19:42:05  Traceback (most recent call last):
19:42:05  
19:42:05    File "C:\.7.x\vendor\depot_tools\gclient_utils.py", line 143, in SyntaxErrorToError
19:42:05      e.lineno, e.offset, re.sub(r'[\r\n]*$', '', e.text))
19:42:05    File "C:\Users\Administrator\.vpython-root\6caf28\lib\re.py", line 208, in sub
19:42:05      return _compile(pattern, flags).sub(repl, string, count)
19:42:05  
19:42:05  TypeError: expected string or bytes-like object

@bsclifton bsclifton force-pushed the pr5301_publisher-list-improvments_1.7.x branch from 3940b1e to 21a69c1 Compare April 24, 2020 08:41
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 5f04d81 into 1.7.x Apr 24, 2020
@bsclifton bsclifton deleted the pr5301_publisher-list-improvments_1.7.x branch April 24, 2020 18:34
@bsclifton bsclifton added this to the 1.7.x - Release Hotfix 2 milestone Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants