Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perturb convertToBlob #4939

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Perturb convertToBlob #4939

merged 1 commit into from
Mar 19, 2020

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Mar 13, 2020

Resolves brave/brave-browser#8682

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@pilgrim-brave pilgrim-brave self-assigned this Mar 13, 2020
@pilgrim-brave pilgrim-brave force-pushed the mpilgrim_convert_to_blob branch 5 times, most recently from c5ded8a to c1d3750 Compare March 18, 2020 22:48
.

add NOLINT

move patch to CanvasAsyncBlobCreator constructor

remove unnecessary includes

.

.

include path to fix Windows build
@pilgrim-brave
Copy link
Contributor Author

CI errors are unrelated (unrelated browser tests timing out)

Travis errors are unrelated (npm security audit)

Builds locally on Mac and Windows, both debug and release (which previously failed). Committing.

@pilgrim-brave pilgrim-brave merged commit d0df5d1 into master Mar 19, 2020
@pilgrim-brave pilgrim-brave deleted the mpilgrim_convert_to_blob branch March 19, 2020 18:10
@bsclifton bsclifton added this to the 1.8.x - Nightly milestone Mar 19, 2020
@bsclifton
Copy link
Member

Added missing milestone to this PR and brave/brave-browser#8682 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convertToBlob farbling
3 participants