Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes ad notifications are not displayed on macOS Catalina (0.72) #3866

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Fixes ad notifications are not displayed on macOS Catalina (0.72) #3866

merged 1 commit into from
Nov 4, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Nov 4, 2019

Fixes brave/brave-browser#6466
Uplift of: #3850

@tmancey @ryanml
Merge pull request #3850 from /issues/6466
75e652b 
Fixes ad notifications are not displayed on macOS Catalina
@ryanml ryanml added this to the 0.72.x - Dev milestone Nov 4, 2019
@ryanml ryanml requested a review from a team November 4, 2019 00:36
@ryanml ryanml requested a review from bridiver as a code owner November 4, 2019 00:36
rebron
rebron approved these changes Nov 4, 2019
View reviewed changes
Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kjozwiak
Copy link
Member

kjozwiak commented Nov 4, 2019

Restarting on macOS due to the following failure as per https://ci.brave.com/job/brave-browser-build-pr/job/uplift-3850-72/1/execution/node/487/log/:

01:36:27  [38374/38640] STAMP obj/chrome/chrome_dll.stamp
01:40:13  Sending interrupt signal to process
01:40:14  Sending interrupt signal to process
01:40:26  ninja: error: remove(Brave Browser Nightly Framework.dSYM): Directory not empty
01:40:26  ninja: build stopped: interrupted by user.
01:40:26  ninja: error: remove(Brave Browser Nightly Framework.dSYM): Directory not empty
01:40:26  script returned exit code 143

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Nov 4, 2019
tmancey
tmancey approved these changes Nov 4, 2019
View reviewed changes
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

bsclifton
bsclifton approved these changes Nov 4, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit fc511fe into 0.72.x Nov 4, 2019
@bsclifton bsclifton deleted the uplift-3850-72 branch November 4, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmancey tmancey tmancey approved these changes

@bsclifton bsclifton bsclifton approved these changes

@rebron rebron rebron approved these changes

@bridiver bridiver Awaiting requested review from bridiver bridiver is a code owner

Assignees

@tmancey tmancey

Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/ads
Projects
None yet
Milestone
1.1.x - Release
Development

Successfully merging this pull request may close these issues.
5 participants
@ryanml @kjozwiak @tmancey @bsclifton @rebron