Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new avatar icon set (uplift to 0.71.x) #3780

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Oct 23, 2019

Uplift of #3771
Fixes brave/brave-browser#6443

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Oct 23, 2019
@brave-builds brave-builds added this to the 0.71.x - Beta milestone Oct 23, 2019
@bsclifton bsclifton requested review from a team and removed request for bridiver, bbondy, kjozwiak, bsclifton, rebron and srirambv October 23, 2019 06:06
@kjozwiak
Copy link
Member

Restarting. Looks like it timed out after ~6mins and never ran correctly.

@kjozwiak
Copy link
Member

Looks like there was lint failures due to ImportError: No module named httplib2 on iOS and macOS which is a known problem and is being addressed by both @bsclifton and @jumde.

Restarting macOS due to npm run audit_deps failing as per https://staging.ci.brave.com/job/brave-browser-build-pr/job/pr3771_profile-icons_0.71.x/1/execution/node/523/log/:

03:44:05  Auditing /Users/jenkins/jenkins/workspace/d-pr_pr3771_profile-icons_0.71.x/src/brave/components/brave_sync/extension/brave-crypto
03:44:05  /Users/jenkins/jenkins/workspace/d-pr_pr3771_profile-icons_0.71.x/src/brave/components/brave_sync/extension/brave-crypto: npm audit
03:44:18  
03:44:18  npm ERR! code ENOAUDIT
03:44:18  npm ERR! audit Your configured registry (https://registry.npmjs.org/) does not support audit requests, or the audit endpoint is temporarily unavailable.

Restarting Win x64 due to the following failure as per:

01:12:49  WindowsError: [Error 123] The filename, directory name, or volume label syntax is incorrect: 'C:\\Users\x07dministrator''

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Oct 28, 2019
@bsclifton
Copy link
Member

rebased 👍

@bsclifton
Copy link
Member

Lint failed- but otherwise, looks good! 👍

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit bf9861a into 0.71.x Oct 29, 2019
@bsclifton bsclifton deleted the pr3771_profile-icons_0.71.x branch October 29, 2019 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants