Fix webtorrent related crash in the network stack (0.69.x)

[iefremov]

Fixes brave/brave-browser#6320

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[bsclifton]

Updating base to be 0.69.x 👍

[yrliou]

LGTM as a temporary workaround.

[bsclifton]

Has a compile error on Android:

14:11:37  ../../brave/browser/net/brave_request_handler.cc:193:3: error: use of undeclared identifier 'webtorrent'
14:11:37    webtorrent::OnHeadersReceived_TorrentRedirectWork(original_response_headers,
14:11:37    ^
14:11:37  1 error generated.

[bsclifton]

Failing on Android; do any other extensions use this flow? (ex: is it OK to call webtorrent::OnHeadersReceived_TorrentRedirectWork in all cases?)

Link to compile error:
https://staging.ci.brave.com/job/brave-browser-build-pr/job/ie_torrent_crash/3/execution/node/477/log/

[yrliou]

Has a compile error on Android:

14:11:37  ../../brave/browser/net/brave_request_handler.cc:193:3: error: use of undeclared identifier 'webtorrent'
14:11:37    webtorrent::OnHeadersReceived_TorrentRedirectWork(original_response_headers,
14:11:37    ^
14:11:37  1 error generated.

Ah, right, webtorrent callback should be guarded with #if BUILDFLAG(ENABLE_BRAVE_WEBTORRENT)

[iefremov]

Ok, fixed! Sorry for that

[yrliou]

macOS failed on init, other platforms are green. I'll try retriggering macOS.

[bsclifton]

++