Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 6193: Run all request callbacks synchronously. #3583

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

iefremov
Copy link
Contributor

@iefremov iefremov commented Oct 2, 2019

Fix brave/brave-browser#6193

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@iefremov iefremov requested a review from bridiver October 2, 2019 16:13
@iefremov iefremov self-assigned this Oct 2, 2019
base::Bind(&BraveRequestHandler::RunNextCallback,
weak_factory_.GetWeakPtr(),
ctx));
RunNextCallback(ctx);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously the async call was needed to keep proper callbacks flow in url_request_http_job.cc (the response callback was called synchronously and this could break things). Now response callbacks are called asynchronously (see RunCallbackForRequestIdentifier) so we can keep normal flow here.

bridiver
bridiver previously approved these changes Oct 3, 2019
@bsclifton
Copy link
Member

Rebased so that CI would run again 👍

@bsclifton
Copy link
Member

Merging, since this was previously approved 😄 CI is now happy also!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash in webtorrent::OnHeadersReceived_TorrentRedirectWork (0.71.x and newer)
3 participants