Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tipping Banner accessibility/style/copy updates #3531

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Tipping Banner accessibility/style/copy updates #3531

merged 1 commit into from
Oct 9, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Sep 25, 2019

Fixes: brave/brave-browser#6147

Submitter Checklist:

Test Plan:

Defined in issue, be sure to have BAT on hand

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml force-pushed the fix-6147 branch 2 times, most recently from 1448f4f to 9bc18d5 Compare September 26, 2019 04:04
@ryanml
Copy link
Contributor Author

ryanml commented Sep 26, 2019

@NejcZdovc per discussion querySelector call was removed, validation happens at the Amount component level, still couldn't nail down a dynamic ref

@masparrow
Copy link
Contributor

@ryanml Changes LGTM, but FYI;

  • Clean install
  • Enable rewards
  • http://vimeo.com/willchristiansen
  • Autoplay is disabled by default (Version 0.72.52 Chromium: 77.0.3865.90 (Developer Build) (64-bit))
  • this causes ‘Page unresponsive’ popups which interferes with tip panel - this is just an FYI with QA in mind

But, with Autoplay enabled;

  • Send tip is focused, but tabbing takes you out of the ‘Tip amount’ pane to the URL, and then tabbing again just goes ‘somewhere’ in the main page behind the Tip panel
  • I’d expect tab to be restricted within the ‘Tip amount’ pane so that; Send Tip -> 1.0 BAT -> 5.0 BAT -> 10.0 BAT -> Make this monthly -> Send Tip -> 1.0 BAT and so on.

@ryanml
Copy link
Contributor Author

ryanml commented Sep 26, 2019

rebased

tmancey
tmancey previously approved these changes Sep 26, 2019
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. airplane icon should be white
    image

  2. click should be on button and not on the whole box (same should be fixed on monthly banner)
    current
    image
    expected
    image

@ryanml ryanml merged commit dc0975f into master Oct 9, 2019
@ryanml ryanml deleted the fix-6147 branch October 9, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tipping Banner should be more accessible
4 participants