Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes panel notifications not showing up #3376

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Sep 6, 2019

Resolves brave/brave-browser#5913

Submitter Checklist:

Test Plan:

steps in brave/brave-browser#5913

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 0.72.x - Nightly milestone Sep 6, 2019
@NejcZdovc NejcZdovc requested review from bsclifton and a team September 6, 2019 06:15
@NejcZdovc NejcZdovc self-assigned this Sep 6, 2019
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 👍

@NejcZdovc NejcZdovc merged commit 514bc23 into master Sep 6, 2019
@NejcZdovc NejcZdovc deleted the panel-notification branch September 6, 2019 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications cannot be dismissed if currentNotification is not in list
2 participants