Uplift "Offer google translate installation in translate bubbles" to 0.69.x #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Offer google translate installation in translate bubbles
yrliou
force-pushed
the
uplift_offer_gtranslate_0.69.x
branch
from
f13f1a1
to
8c16179
Compare
|
CI only failed on |
32 tasks
kjozwiak
approved these changes
Aug 21, 2019
There was a problem hiding this comment.
Uplift into 0.69.x approved after deliberating with @brave/uplift-approvers. I also went through some QA #3103 (comment) as per @bbondy request. Both CI/Travis and CI/Jenkins look good as per #3177 (comment).
Please make sure that all the correct labels are added and the associated issue is moved into the correct milestone.
bridiver
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: brave/brave-browser#5561
PR: #3103