Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylesheet injection for cosmetic filtering #3002

Closed
wants to merge 1 commit into from

Conversation

Snuupy
Copy link
Contributor

@Snuupy Snuupy commented Jul 24, 2019

Submitter Checklist:

closes brave/brave-browser#3041, brave/brave-browser#4348, brave/brave-browser#4338

and brave/brave-browser#94 (comment)

Test Plan:

Block element with !important html tag or is asynchronously added to the webpage (ex. reddit/facebook with filters added) and see that those ads are blocked.

    1. Visit https://new.reddit.com/
    1. add .promotedlink to filter
    1. scroll down to see promoted links/advertisements (master will not be able to block the promoted links, but this PR will)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@Snuupy Snuupy self-assigned this Jul 24, 2019
@Snuupy Snuupy added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Jul 24, 2019
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Snuupy I'm sure this makes sense, but please can you put a test plan for each issue (on the issues preferrably) that is not reproducible on this branch, but is reproducible in master.

For example I tried the STR in brave/brave-browser#4338 but could not see a difference between master and this branch. I added a custom rule in both versions for #header-right-section and it seemed to work for both.

Thanks!

@Snuupy
Copy link
Contributor Author

Snuupy commented Jul 31, 2019

@Snuupy I'm sure this makes sense, but please can you put a test plan for each issue (on the issues preferrably) that is not reproducible on this branch, but is reproducible in master.

For example I tried the STR in brave/brave-browser#4338 but could not see a difference between master and this branch. I added a custom rule in both versions for #header-right-section and it seemed to work for both.

Thanks!

@petemill

I have 2 tests that show this PR works (and the master branch does not):

    1. Visit https://new.reddit.com/
    1. add .promotedlink to filter
    1. scroll down to see promoted links/advertisements (master will not be able to block the promoted links if they are loaded after the page has finished loading, but this PR will)

Edited PR text to include the above instructions.

@Snuupy Snuupy mentioned this pull request Aug 8, 2019
31 tasks
@petemill
Copy link
Member

petemill commented Aug 9, 2019

Closed in favor of #3121

@petemill petemill closed this Aug 9, 2019
@petemill petemill deleted the stylesheetInjection branch August 9, 2019 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosmetic filter - use !important for display property
2 participants