add exception for socket.io endpoint on sliver.tv #2975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm but deferring this type of change to security to approve. |
fmarier
previously approved these changes
Jul 24, 2019
|
@snyderp Is there a bug you can link to from this PR (and close in the commit message)? |
pes10k
force-pushed
the
add-3p-cookie-exception-for-sliver
branch
from
5d459b7
to
579d0aa
Compare
|
@fmarier done and done :) |
|
(It says i "dismissed" your review above. Hope i didn't do anything wrong / rude accidentally!) |
fmarier
approved these changes
Jul 24, 2019
brave-builds
pushed a commit
that referenced
this pull request
Jul 25, 2019
brave-builds
pushed a commit
that referenced
this pull request
Jul 25, 2019
brave-builds
pushed a commit
that referenced
this pull request
Jul 25, 2019
This was referenced Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#5380
This fixes a problem with socket.io integration for sliver.tv by allowing 3p cookies on
https://*.thetatoken.org:8700/.