Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Auto Contribution #2853

Merged
merged 2 commits into from
Sep 19, 2019
Merged

GitHub Auto Contribution #2853

merged 2 commits into from
Sep 19, 2019

Conversation

jdkuki
Copy link
Contributor

@jdkuki jdkuki commented Jul 3, 2019

Implementation for GitHub auto contribution
Depends on #2795
Resolves brave/brave-browser#5120

Submitter Checklist:

Test Plan:

See brave/brave-browser#5120

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jdkuki jdkuki marked this pull request as ready for review July 3, 2019 18:54
@jdkuki jdkuki self-assigned this Jul 3, 2019
@jdkuki jdkuki added this to the 0.69.x - Nightly milestone Jul 3, 2019
@jdkuki jdkuki requested a review from NejcZdovc July 3, 2019 22:30
@jdkuki jdkuki force-pushed the github-ac branch 3 times, most recently from cc795f8 to 28b80c6 Compare July 24, 2019 18:24
@jdkuki jdkuki force-pushed the github-ac branch 2 times, most recently from 16b2c4d to a0ef1ad Compare August 7, 2019 04:06
@bsclifton bsclifton removed this from the 0.71.x - Dev milestone Sep 12, 2019
@bsclifton
Copy link
Member

Removing milestone as this is not reviewed/approved/merged 👍

@NejcZdovc NejcZdovc merged commit 667e94e into master Sep 19, 2019
@NejcZdovc NejcZdovc deleted the github-ac branch September 19, 2019 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Auto Contribution
3 participants