Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade patches from Chromium 75.0.3770.90 to Chromium 75.0.3770.100 (0.65.x) #2732

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Upgrade patches from Chromium 75.0.3770.90 to Chromium 75.0.3770.100 (0.65.x) #2732

merged 1 commit into from
Jun 19, 2019

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#4962
Related: brave/brave-browser#4972

Uplift request from #2728

@mkarolin
Merge pull request #2728 from brave/75.0.3770.100_master_33
d72b050 
Upgrade patches from Chromium 75.0.3770.90 to Chromium 75.0.3770.100
@mkarolin mkarolin added this to the 0.65.x - Release Hotfix 2 milestone Jun 18, 2019
@mkarolin mkarolin self-assigned this Jun 18, 2019
@mkarolin mkarolin mentioned this pull request Jun 18, 2019
Merged
@mkarolin mkarolin requested a review from a team June 18, 2019 20:56
@mkarolin mkarolin changed the title Upgrade patches from Chromium 75.0.3770.90 to Chromium 75.0.3770.100 Upgrade patches from Chromium 75.0.3770.90 to Chromium 75.0.3770.100 (0.65.x) Jun 18, 2019
@kjozwiak
Copy link
Member

@mkarolin mind taking a look at this one? There's a few JS errors at the end of the log, example:

java.io.EOFException
	at java.base/java.io.ObjectInputStream$PeekInputStream.readFully(ObjectInputStream.java:2763)
	at java.base/java.io.ObjectInputStream$BlockDataInputStream.readShort(ObjectInputStream.java:3258)
	at java.base/java.io.ObjectInputStream.readStreamHeader(ObjectInputStream.java:873)
	at java.base/java.io.ObjectInputStream.<init>(ObjectInputStream.java:350)
	at hudson.remoting.ObjectInputStreamEx.<init>(ObjectInputStreamEx.java:49)
	at hudson.remoting.Command.readFrom(Command.java:140)
	at hudson.remoting.Command.readFrom(Command.java:126)
	at hudson.remoting.AbstractSynchronousByteArrayCommandTransport.read(AbstractSynchronousByteArrayCommandTransport.java:36)
	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:63)
Caused: java.io.IOException: Unexpected termination of the channel
	at hudson.remoting.SynchronousCommandTransport$ReaderThread.run(SynchronousCommandTransport.java:77)

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Jun 19, 2019
@mkarolin mkarolin added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jun 19, 2019
@mkarolin
Copy link
Collaborator Author

mkarolin commented Jun 19, 2019 •
edited
Loading

Mac and Linux passed the CI in build 4, Win passed in build 5

srirambv
srirambv approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@srirambv srirambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ Approved after deliberating with @bbondy. Please update the labels and milestones accordingly.

@mkarolin mkarolin merged commit fc8179c into 0.65.x Jun 19, 2019
@mkarolin mkarolin deleted the 75.0.3770.100-0.65.x branch June 19, 2019 13:36
@mkarolin mkarolin removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jun 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srirambv srirambv srirambv approved these changes

Assignees

@mkarolin mkarolin

Labels
None yet
Projects
None yet
Milestone
0.65.x - Release Hotfix 2
Development

Successfully merging this pull request may close these issues.
3 participants
@mkarolin @kjozwiak @srirambv