Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification permission when user tries to turn on the VPN #27250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Jan 15, 2025

Resolves brave/brave-browser#43019

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

On devices with > android 12, we need to ask for notification permission.
And since we removed the permission from onboarding, we are adding it for VPN when user tries to turn on the VPN.

  1. Install fresh profile
  2. Buy a subscription
  3. Try to Install vpn profile
  4. Observe that as soon as we established the connection, app would show the system dialog to ask notification permission
  5. Tap Don't allow so that we can trigger the same system dialog again from different entry point
  6. Go to NTP
  7. Disconnect the VPN
  8. From main menu, Tap on Brave VPN
  9. Observer that after vpn connection is established, app shows the system dialog again

Note : we have rate limit on showing the permission in the app.

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Jan 15, 2025
@deeppandya deeppandya added this to the 1.76.x - Nightly milestone Jan 15, 2025
@deeppandya deeppandya self-assigned this Jan 15, 2025
&& Build.VERSION.SDK_INT >= Build.VERSION_CODES.TIRAMISU) {
// Check if the POST_NOTIFICATIONS permission is already granted
if (ContextCompat.checkSelfPermission(context, Manifest.permission.POST_NOTIFICATIONS)
!= PackageManager.PERMISSION_GRANTED) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could combine that if with the if above

Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Add notification permission for VPN
3 participants