Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lion animation onboarding #27239

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Remove lion animation onboarding #27239

merged 3 commits into from
Jan 16, 2025

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Jan 14, 2025 •
edited
Loading

Resolves brave/brave-browser#43116
Resolves brave/brave-browser#43290

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Recording for < android 10 devices
    https://github.com/user-attachments/assets/d33fa716-1c97-4241-a8a6-9441a81c1d25

  2. Recording for > android 9 devices
    https://github.com/user-attachments/assets/fe69e799-6ae7-4fa7-9e78-7302b887f498

@deeppandya deeppandya added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Jan 14, 2025
@deeppandya deeppandya added this to the 1.76.x - Nightly milestone Jan 14, 2025
@deeppandya deeppandya self-assigned this Jan 14, 2025
@deeppandya deeppandya requested a review from a team as a code owner January 14, 2025 20:13
mkarolin
mkarolin approved these changes Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings++

samartnik
samartnik approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@deeppandya deeppandya force-pushed the remove_lion_animation_onboarding branch from ace8e8b to 3dde926 Compare January 15, 2025 17:36
mherrmann
mherrmann approved these changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@mherrmann mherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions. My personal preference would be that you implement those that are not marked as "feel free to ignore". But they are all style preferences more than anything else. I'm unlocking so you can also merge as-is if you prefer.

android/java/org/chromium/chrome/browser/firstrun/WelcomeOnboardingActivity.java
Comment on lines +58 to +63
* Activity that handles the first run onboarding experience for new Brave browser installations.
* Extends FirstRunActivityBase to provide onboarding flows for: - Setting Brave as default browser
* - Configuring privacy and analytics preferences (P3A and crash reporting) - Accepting terms of
* service The activity guides users through a series of steps using animations and clear UI
* elements to explain Brave's key features and privacy-focused approach.
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Activity that handles the first run onboarding experience for new Brave browser installations.
* Extends FirstRunActivityBase to provide onboarding flows for: - Setting Brave as default browser
* - Configuring privacy and analytics preferences (P3A and crash reporting) - Accepting terms of
* service The activity guides users through a series of steps using animations and clear UI
* elements to explain Brave's key features and privacy-focused approach.
*/
* Activity that handles the first run onboarding experience for new Brave browser installations.
* Extends FirstRunActivityBase to provide onboarding flows for:
* - Setting Brave as default browser
* - Configuring privacy and analytics preferences (P3A and crash reporting)
* - Accepting terms of service
* The activity guides users through a series of steps using animations and clear UI
* elements to explain Brave's key features and privacy-focused approach.
*/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mherrmann That's exactly what i had initially but presubmit fails with it so i had to update it. CI was failing with comment's formatting

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. That's a pity :/

android/java/org/chromium/chrome/browser/firstrun/WelcomeOnboardingActivity.java Outdated
assert !mInitializeViewsDone;

// Set the content view to the welcome onboarding layout
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this comment superfluous and would remove it.

android/java/org/chromium/chrome/browser/firstrun/WelcomeOnboardingActivity.java Outdated
mIsTablet = DeviceFormFactor.isNonMultiDisplayContextOnTablet(this);

// Initialize view references and setup
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this comment superfluous and would remove it.

android/java/org/chromium/chrome/browser/firstrun/WelcomeOnboardingActivity.java Outdated
initViews();

// Setup click listeners for interactive elements
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the comment and instead rename onClickViews to setupClickListeners.

android/java/org/chromium/chrome/browser/firstrun/WelcomeOnboardingActivity.java Outdated
if (mInvokePostWorkAtInitializeViews) {
finishNativeInitializationPostWork();
}

// Check install referral data
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this comment superfluous and would remove it.

android/java/org/chromium/chrome/browser/firstrun/WelcomeOnboardingActivity.java Outdated
}
// Final step: Complete onboarding
else {
// Set onboarding preferences
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this comment because it says the same thing as the following method invocations.

android/java/org/chromium/chrome/browser/firstrun/WelcomeOnboardingActivity.java Outdated
OnboardingPrefManager.getInstance().setP3aOnboardingShown(true);
OnboardingPrefManager.getInstance().setOnboardingSearchBoxTooltip(true);

// Mark first run flow as complete
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this comment because it says the same thing as the following method invocation.

android/java/org/chromium/chrome/browser/firstrun/WelcomeOnboardingActivity.java Outdated
FirstRunStatus.setFirstRunFlowComplete(true);

// Accept terms of service and EULA
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this comment because it says the same thing as the following method invocations.

android/java/org/chromium/chrome/browser/firstrun/WelcomeOnboardingActivity.java
UmaSessionStats.changeMetricsReportingConsent(
true, ChangeMetricsReportingStateCalledFrom.UI_FIRST_RUN);
// Mark crash reporting message as shown
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this comment because it says the same thing as the following method invocation.

android/java/org/chromium/chrome/browser/firstrun/WelcomeOnboardingActivity.java
boolean isCrashReporting = false;
try {
// Get current crash reporting permission status
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this comment because it says the same thing as the following method invocation.

@deeppandya deeppandya force-pushed the remove_lion_animation_onboarding branch from 3dde926 to fe7033f Compare January 16, 2025 20:39
@deeppandya deeppandya merged commit add5e19 into master Jan 16, 2025
18 checks passed
@deeppandya deeppandya deleted the remove_lion_animation_onboarding branch January 16, 2025 22:15
@brave-builds
Copy link
Collaborator

Released in v1.76.21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mherrmann mherrmann mherrmann approved these changes

@mkarolin mkarolin mkarolin approved these changes

@samartnik samartnik samartnik approved these changes

Assignees

@deeppandya deeppandya

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.76.x - Nightly
Development

Successfully merging this pull request may close these issues.

[Android] Remove new onboarding flag changes [Android] Remove lion animation from onboarding
5 participants
@deeppandya @brave-builds @mherrmann @samartnik @mkarolin