[iOS] - Improve QRCode Scanning Visibility #27229
Open
+79
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brandon-T
added
CI/skip-android
| private var onDidScan: (_ string: String) -> Void | ||
|
|
||
| private var didProcessScanReusltsTask: Task<Void, Error>? |
There was a problem hiding this comment.
I don't see this used anywhere or any Task's created, I assume can be deleted?
stoletheminerals
approved these changes
Jan 15, 2025
| } | ||
| } | ||
|
|
||
| private(set) lazy var scannedDisplayButton = UIButton().then { |
There was a problem hiding this comment.
Dont see any reason for this to be lazy
| $0.titleLabel?.font = UIFont.preferredFont(forTextStyle: .body) | ||
| $0.titleLabel?.lineBreakMode = .byTruncatingTail | ||
| $0.setTitleColor(.white, for: .normal) | ||
| $0.backgroundColor = UIColor(braveSystemName: .primitivePurple60) |
There was a problem hiding this comment.
Should be buttonBackground
There was a problem hiding this comment.
If this button isnt themed for some reason you can ignore this and the comment below
| $0.contentEdgeInsets = UIEdgeInsets(top: 12, left: 16, bottom: 12, right: 16) | ||
| $0.titleLabel?.font = UIFont.preferredFont(forTextStyle: .body) | ||
| $0.titleLabel?.lineBreakMode = .byTruncatingTail | ||
| $0.setTitleColor(.white, for: .normal) |
There was a problem hiding this comment.
Should be schemesOnPrimary
kylehickinson
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves brave/brave-browser#42559
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: