Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Don't read pasteboard for text when evaluating search suggestions #27212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kylehickinson
Copy link
Collaborator

This change alters how we determine if some text was inserted by pasting contents from the pasteboard for users using keyboards that assemble words/characters using multiple key inputs.

Resolves brave/brave-browser#42526

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

This change alters how we determine if some text was inserted by pasting contents from the pasteboard for users using keyboards that assemble words/characters using multiple key inputs.
@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-teamcity Do not run builds in TeamCity labels Jan 13, 2025
@kylehickinson kylehickinson self-assigned this Jan 13, 2025
@kylehickinson kylehickinson requested a review from a team as a code owner January 13, 2025 20:28
@@ -119,6 +119,10 @@ class TopToolbarView: UIView, ToolbarProtocol {
locationTextField?.lastReplacement ?? ""
}

var isPastingInURLBar: Bool {
locationTextField?.isPasting ?? false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: isPasting == true

@@ -92,6 +92,9 @@ public class AutocompleteTextField: UITextField, UITextFieldDelegate {
self,
didEnterText: self.text?.preferredSearchSuggestionText ?? ""
)
if self.isPasting {
self.isPasting = false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: You can do self.isPasting = false without the if-check I think. If it's true, it gets set to false. If it's already false, it's set to false. No branches :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-teamcity Do not run builds in TeamCity CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave asks the user to paste from their clipboard when typing with the Kana Japanese keyboard
3 participants