Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resolving on Base chain for UD #27199

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

supermassive
Copy link
Collaborator

@supermassive supermassive commented Jan 13, 2025

Resolves brave/brave-browser#42983

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Newly added TLDs should be resolvable brave/brave-browser#42368
Support of TLDs added before should not break.

@github-actions github-actions bot added the CI/run-network-audit Run network-audit label Jan 14, 2025
@supermassive supermassive marked this pull request as ready for review January 14, 2025 11:43
@supermassive supermassive requested review from a team and iefremov as code owners January 14, 2025 11:43
@supermassive supermassive merged commit 13206b1 into master Jan 15, 2025
20 checks passed
@supermassive supermassive deleted the support_base_for_ud branch January 15, 2025 03:46
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 15, 2025
brave-builds added a commit that referenced this pull request Jan 15, 2025
@brave-builds
Copy link
Collaborator

Released in v1.76.16

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.76.16 Chromium: 132.0.6834.83 (Official Build) nightly (64-bit)
Revision efda3cc
OS Windows 11 Version 23H2 (Build 22631.4602)
  • Verified steps from #26703
  • Verified new UD domains are resolved correctly
27199.mp4

kjozwiak pushed a commit that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newly added UD TLD's don't resolve
5 participants