Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #24550 from brave/cr127-followup-disable-s… (uplift to 1.68.x) #24672

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Revert "Merge pull request #24550 from brave/cr127-followup-disable-s… (uplift to 1.68.x) #24672

merged 1 commit into from
Jul 17, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jul 16, 2024 •
edited by kjozwiak

Uplift of #24670
Resolves brave/brave-browser#39767

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner July 16, 2024 12:53
@brave-builds brave-builds added this to the 1.68.x - Beta milestone Jul 16, 2024
@brave-builds brave-builds self-assigned this Jul 16, 2024
@github-actions github-actions bot added CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels Jul 16, 2024
kjozwiak
kjozwiak approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.68.x approved 👍 QA has verified the PR on Nightly using 1.69.x as per #24670 (comment).

@kjozwiak kjozwiak merged commit 4ebc5d6 into 1.68.x Jul 17, 2024
15 checks passed
@kjozwiak kjozwiak deleted the pr24670_revert-issues/39615_1.68.x branch July 17, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Milestone
1.68.x - Release
2 participants
@brave-builds @kjozwiak