Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Strings] Use contractions wherever possible #24635

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

jagadeshjai
Copy link
Collaborator

@jagadeshjai jagadeshjai commented Jul 12, 2024

  • Use contractions wherever possible in brave_settings_strings.grdp

Resolves brave/brave-browser#39729

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#39729

@jagadeshjai jagadeshjai marked this pull request as ready for review July 12, 2024 19:33
@jagadeshjai jagadeshjai requested a review from a team as a code owner July 12, 2024 19:33
@jagadeshjai
Copy link
Collaborator Author

@mkarolin Could you please take a look at this PR?

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ++

@bsclifton bsclifton merged commit cc155d9 into brave:master Jul 16, 2024
21 checks passed
@bsclifton bsclifton added this to the 1.69.x - Nightly milestone Jul 16, 2024
@stephendonner
Copy link
Contributor

@jagadeshjai comes through again ++

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@jagadeshjai jagadeshjai deleted the fix__possible_contraction branch July 17, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants