Adds additional balance check #2091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
force-pushed
the
balance-check
branch
from
d32a943
to
9e7e29e
Compare
NejcZdovc
force-pushed
the
balance-check
branch
from
9e7e29e
to
cba09ed
Compare
NejcZdovc
requested review from
yrliou,
jasonrsadler,
bridiver and
ryanml
and removed request for
yrliou and
jasonrsadler
NejcZdovc
changed the title
ryanml
approved these changes
Mar 27, 2019
NejcZdovc
commented
Mar 28, 2019
| std::unique_ptr<ledger::WalletInfo> wallet_info) { | ||
| TriggerOnWalletProperties(result, std::move(wallet_info)); | ||
| if (wallet_info && wallet_info->balance_ > 0) { |
There was a problem hiding this comment.
logic from TriggerOnWalletProperties was moved in this function
NejcZdovc
added a commit
that referenced
this pull request
Apr 3, 2019
Adds additional balance check
|
@NejcZdovc are there any tests for this change? |
|
@bsclifton not particular, just existing ones. Contribution flow will be covered with this tests #1804 |
NejcZdovc
added a commit
that referenced
this pull request
Apr 4, 2019
Merge pull request #2091 from brave/balance-check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#3897
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: