Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wallet): bump @brave/swap-interface to v0.15.2 #17312

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Conversation

onyb
Copy link
Member

@onyb onyb commented Feb 21, 2023

Resolves brave/brave-browser#28618
Resolves brave/brave-browser#28623
Resolves brave/brave-browser#28630
Resolves brave/brave-browser#28631
Resolves brave/brave-browser#28635

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See linked issues.

@onyb onyb requested a review from a team as a code owner February 21, 2023 20:36
@onyb onyb self-assigned this Feb 21, 2023
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Feb 21, 2023
Copy link
Contributor

@Douglashdaniel Douglashdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Member

@kdenhartog kdenhartog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't change any transient dependencies and just a version bump - unblocking js dependency review

@onyb onyb merged commit ade1853 into master Feb 22, 2023
@onyb onyb deleted the bump-swap-v0.15.2 branch February 22, 2023 04:11
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 22, 2023
brave-builds added a commit that referenced this pull request Feb 23, 2023
@srirambv
Copy link
Contributor

srirambv commented Mar 1, 2023

Verification passed on

Brave 1.49.108 Chromium: 110.0.5481.104 (Official Build) beta (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Linux

Verified all the linked issues individually

https://github.com/brave/brave-browser/issues/28618 - Pass
  • Verified deleting swap input resets swap quotes
28618.mp4
https://github.com/brave/brave-browser/issues/28623 - Pass
  • Verified cannot place order on Solana Swap when there is no enough token balance
  • Verified Review order is disabled if the balance is insufficient
  • Verified Review order button changes to Insufficient XXX balance and is disabled preventing user to place order on a token without any balance
image image
https://github.com/brave/brave-browser/issues/28630 - Pass
  • Verified fetching swap quotes is reset when input is deleted during in-flight
  • Encountered #28819
28630.mp4
https://github.com/brave/brave-browser/issues/28631 - Pass
  • Verified swap quote request is only done after 1sec of entering the input value
https://github.com/brave/brave-browser/issues/28635 - Pass
  • Verified token balance is updated on loading portfolio page and when switching networks or accounts

kjozwiak pushed a commit that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps)
Projects
None yet
4 participants