-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(wallet): bump @brave/swap-interface to v0.15.2 #17312
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't change any transient dependencies and just a version bump - unblocking js dependency review
Verification passed on
Verified all the linked issues individually
|
https://github.com/brave/brave-browser/issues/28630 - Pass
- Verified fetching swap quotes is reset when input is deleted during in-flight
- Encountered #28819
28630.mp4
https://github.com/brave/brave-browser/issues/28631 - Pass
- Verified swap quote request is only done after 1sec of entering the input value
https://github.com/brave/brave-browser/issues/28635 - Pass
- Verified token balance is updated on loading portfolio page and when switching networks or accounts
Resolves brave/brave-browser#28618
Resolves brave/brave-browser#28623
Resolves brave/brave-browser#28630
Resolves brave/brave-browser#28631
Resolves brave/brave-browser#28635
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
See linked issues.