Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Virtualized Token List Dynamic Height #17110

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

Douglashdaniel
Copy link
Contributor

Description

Makes the Virtualized Token List have dynamic heights to prevent overlapping and squishing.

Resolves brave/brave-browser#28276
Resolves brave/brave-browser#28275

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Add a custom NFT with a really long name (Example: NFT with a really long display name for testing in place throughout the wallet)
  2. Reopen the Edit Visible Assets modal and scroll down to your long named NFT
  3. The Icon should not be squished and the text should not overlap other tokens.

Before:

4

3

After:

6

5

@Douglashdaniel Douglashdaniel self-assigned this Feb 8, 2023
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner February 8, 2023 18:12
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 8, 2023
Copy link
Contributor

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@Douglashdaniel Douglashdaniel force-pushed the fix-virtualized-token-list-height branch from c18bd5d to 5d1891c Compare February 8, 2023 19:21
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
3 participants