Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirect modal for provider unavailable scenario #15627

Merged

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Oct 24, 2022

Resolves brave/brave-browser#25125

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

UI

provider-unavailable-modal

Test Plan:

  • Clean profile
  • Enable Rewards
  • Connect wallet to bitFlyer/Gemini/Uphold
  • Confirm connection succeeds as expected
  • Disconnect wallet
  • Ask server team to temporarily disable provider linking on staging
  • Connect wallet to bitFlyer/Gemini/Uphold
  • Confirm that you get the "provider unavailable" modal and the wallet fails to connect
  • Confirm that link takes you to Brave's server status page

@emerick emerick self-assigned this Oct 24, 2022
@emerick emerick requested a review from a team as a code owner October 24, 2022 15:49
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 24, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@szilardszaloki
Copy link
Collaborator

Hey @emerick, 🙂
Would you mind adding a screenshot of the new modal? Thanks!

Comment on lines +140 to +143
{
"message": "Error validating Connecting Brave Rewards to Uphold is temporarily unavailable. Please try again later",
"code": 400
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ran into this myself 😄, this is what we get back:

{
  "code": 400,
  "data": {
    "validationErrors": null
  },
  "message": "Error validating Connecting Brave Rewards to Uphold is temporarily unavailable.  Please try again later"
}

Copy link
Collaborator

@szilardszaloki szilardszaloki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@emerick
Copy link
Contributor Author

emerick commented Oct 26, 2022

SonarCloud failed due to a known code-duplication warning in our redirect modal code. Outside of that, CI passed on all platforms so this is ready for merge.

@emerick emerick merged commit c1b55bc into master Oct 26, 2022
@emerick emerick deleted the emerick-rewards-add-provider-unavailable-redirect-modal branch October 26, 2022 16:12
@emerick emerick added this to the 1.47.x - Nightly milestone Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement "custodial connection unavailable" error modal
4 participants