Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BraveShieldsDisabledForUrls and BraveShieldsEnabledForUrls policies #15409

Merged
merged 11 commits into from
Nov 8, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Oct 11, 2022

Resolves brave/brave-browser#25394

  • Added BraveShieldsDisabledForUrls to disable shields urls
  • Added BraveShieldsEnabledForUrls to enable shields urls

Urls set by policies are protected from editing via popup or other ways

image

image

image

image

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Enable policy values in Computer\HKEY_CURRENT_USER\SOFTWARE\Policies\BraveSoftware\Brave and check that settings set by policy cannot be changed by user and work as expected

@spylogsster spylogsster requested review from bridiver, bsclifton and a team October 11, 2022 12:48
@spylogsster spylogsster self-assigned this Oct 11, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 11, 2022
@spylogsster spylogsster force-pushed the brave-25394 branch 2 times, most recently from 9aafa67 to 1f1a3d7 Compare October 11, 2022 13:05
@spylogsster spylogsster requested a review from a team as a October 11, 2022 17:08
@spylogsster spylogsster force-pushed the brave-12782 branch 3 times, most recently from 5bf00d0 to ba24e0f Compare October 13, 2022 08:00
@spylogsster spylogsster force-pushed the brave-12782 branch 5 times, most recently from 7f46ec4 to b83cc84 Compare October 14, 2022 06:53
Base automatically changed from brave-12782 to master October 14, 2022 08:53
@spylogsster spylogsster force-pushed the brave-25394 branch 10 times, most recently from 8cef90b to 4181cd5 Compare October 15, 2022 11:34
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@spylogsster spylogsster merged commit 5bef317 into master Nov 8, 2022
@spylogsster spylogsster deleted the brave-25394 branch November 8, 2022 14:52
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create group policy options for Shields
6 participants