Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed toolbar button color isn't selected properly for custom theme #15208

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Sep 25, 2022

fix brave/brave-browser#25597

Don't overwrite chrome theme's color when custom theme is used on norma profile.

Custom theme from webstore:
image
Brave dark:
image
Brave light:
image

GTK theme on linux
image

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

BraveThemeServiceTest.ColorProviderTest

See the linked issue for manual testing

@simonhong simonhong self-assigned this Sep 25, 2022
@simonhong simonhong force-pushed the fix_webstore_theme_color branch 2 times, most recently from 6daf7e5 to bcb37bc Compare September 25, 2022 03:18
@simonhong simonhong marked this pull request as ready for review September 26, 2022 03:13
@simonhong simonhong requested a review from a team as a code owner September 26, 2022 03:13
fix brave/brave-browser#25597
fix brave/brave-browser#25601

Don't overwrite chrome theme's color when custom theme is used on
norma profile.
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits 👍

@@ -0,0 +1,18 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not sure we can add comments to json file type.

browser/themes/brave_theme_service_browsertest.cc Outdated Show resolved Hide resolved
browser/ui/color/brave_color_mixer.cc Show resolved Hide resolved
Copy link
Contributor

@iefremov iefremov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants