Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Gradient background for NTP (uplift to 1.44.x) #14960

Closed
wants to merge 1 commit into from

Conversation

sangwoo108
Copy link
Contributor

@sangwoo108 sangwoo108 commented Sep 2, 2022

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

* Reuse most of components used for Solid color background
@sangwoo108 sangwoo108 added this to the 1.44.x - Beta milestone Sep 2, 2022
@sangwoo108 sangwoo108 self-assigned this Sep 2, 2022
@sangwoo108 sangwoo108 requested a review from a team as a code owner September 2, 2022 06:06
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Sep 2, 2022
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@sangwoo108 sangwoo108 closed this Sep 14, 2022
@kjozwiak kjozwiak deleted the sko/gradient-uplift branch September 14, 2022 17:16
@kjozwiak kjozwiak removed the request for review from a team September 14, 2022 17:16
@kjozwiak kjozwiak removed the CI/storybook-url Deploy storybook and provide a unique URL for each build label Sep 14, 2022
@kjozwiak kjozwiak removed this from the 1.44.x - Beta milestone Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants