Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retire DoH for UD and ENS #13354

Merged
merged 5 commits into from
May 20, 2022
Merged

Retire DoH for UD and ENS #13354

merged 5 commits into from
May 20, 2022

Conversation

supermassive
Copy link
Collaborator

@supermassive supermassive commented May 17, 2022 •
edited
Loading

Resolves brave/brave-browser#22149

  • Removed DNS over HTTPS code. Users having this turned on will have pref reset to default.
  • Inlined DecentralizedDns feature
  • Cleaned usage of DECENTRALIZED_DNS_ENABLED buildflag

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@supermassive supermassive requested review from a team as code owners May 17, 2022 05:56
@github-actions github-actions bot added the CI/run-network-audit Run network-audit label May 17, 2022
@supermassive supermassive added this to the 1.40.x - Nightly milestone May 17, 2022
supermassive
supermassive commented May 17, 2022
View reviewed changes
...um/chrome/browser/decentralized_dns/settings/RadioButtonGroupENSResolveMethodPreference.java
@@ -54,9 +54,9 @@ public void onBindViewHolder(PreferenceViewHolder holder) {
mButtons.set(ResolveMethodTypes.DISABLED,
(RadioButtonWithDescription) holder.findViewById(
R.id.ens_resolve_method_disabled_radio_button));
mButtons.set(ResolveMethodTypes.DNS_OVER_HTTPS,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ETHEREUM was missing here.

@supermassive supermassive requested a review from a team as a code owner May 17, 2022 11:41
@supermassive supermassive changed the title [WiP] Retire DoH Retire DoH May 17, 2022
@supermassive supermassive changed the title Retire DoH Retire DoH for UD and ENS May 17, 2022
iefremov
iefremov approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@iefremov iefremov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

browser/net/* LGTM, haven't checked anything else

goodov
goodov reviewed May 19, 2022
View reviewed changes
browser/decentralized_dns/test/BUILD.gn
@@ -36,8 +33,6 @@ source_set("unit_tests") {
"//brave/browser/decentralized_dns/test/decentralized_dns_navigation_throttle_unittest.cc",
"//brave/browser/decentralized_dns/test/utils_unittest.cc",
"//brave/browser/net/decentralized_dns_network_delegate_helper_unittest.cc",
"//brave/net/dns/brave_resolve_context_unittest.cc",
"//brave/net/dns/dns_transaction_unittest.cc",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can drop brave_dns_friend now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done in ac27449

yrliou
yrliou approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@supermassive supermassive merged commit d1446fb into master May 20, 2022
@supermassive supermassive deleted the Remove_DoH_for_UD branch May 20, 2022 13:47
supermassive added a commit that referenced this pull request May 23, 2022
@supermassive
Uplift of #13354 (squashed) to beta
b9bbf13
@supermassive supermassive mentioned this pull request May 23, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented May 30, 2022 •
edited
Loading

@srirambv verified the above on Nightly via #13427 (comment).

@srirambv srirambv mentioned this pull request Jun 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodov goodov goodov left review comments

@iefremov iefremov iefremov approved these changes

@yrliou yrliou yrliou approved these changes

Assignees

@supermassive supermassive

Labels
CI/run-network-audit Run network-audit
Projects
None yet
Milestone
1.41.x - Release
Development

Successfully merging this pull request may close these issues.

Retire the option of using DNS over HTTPS for unstoppable domains resolution
5 participants
@supermassive @kjozwiak @iefremov @yrliou @goodov