Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass chain ID parameter in JsonRpcService GetERC721OwnerOf #12790

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Conversation

nvonpentz
Copy link
Member

@nvonpentz nvonpentz commented Mar 28, 2022

Resolves brave/brave-browser#21941

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Add an mainnet Ethereum ERC721 NFT as a custom asset - it should appear under 'NFTs' in your Portfolio
  2. Switch to a different network
  3. Refresh the page, the NFT should still be visible with a balance

@nvonpentz nvonpentz added this to the 1.39.x - Nightly milestone Mar 28, 2022
@nvonpentz nvonpentz marked this pull request as ready for review March 28, 2022 21:49
@nvonpentz nvonpentz requested a review from a team as a code owner March 28, 2022 21:49
@github-actions github-actions bot added rebase and removed rebase labels Mar 28, 2022
@yrliou yrliou self-requested a review March 28, 2022 22:15
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ assuming green CI

components/brave_wallet/browser/json_rpc_service.cc Outdated Show resolved Hide resolved
Comment on lines -1364 to -1365
auto network_url = GetNetworkURL(prefs_, chain_id, mojom::CoinType::ETH);
if (eth_account_address.IsEmpty() || !network_url.is_valid()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh I should catch it in the previous review since network_url is not actually used before this PR.

@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.39.47 Chromium: 100.0.4896.79 (Official Build) nightly (64-bit)
-- | --
Revision | 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS | Windows 11 Version 21H2 (Build 22000.593)

Verified the STR/Cases outlined via #12790 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getERC721TokenBalance Parsing Error
3 participants