Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip referrer and origin headers in xorigin requests from a .onion (uplift to 1.33.x) #11186

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Strip referrer and origin headers in xorigin requests from a .onion (uplift to 1.33.x) #11186

merged 1 commit into from
Nov 26, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 19, 2021 •
edited by kjozwiak
Loading

Uplift of #10760 for brave/brave-browser#18071, originally reported on https://hackerone.com/reports/1337624.

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested review from iefremov and a team as code owners November 19, 2021 23:06
@brave-builds brave-builds requested a review from a team November 19, 2021 23:06
@brave-builds brave-builds self-assigned this Nov 19, 2021
@brave-builds brave-builds added this to the 1.33.x - Beta milestone Nov 19, 2021
@fmarier fmarier self-assigned this Nov 19, 2021
kjozwiak
kjozwiak approved these changes Nov 26, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.33.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #10760 (comment).

@kjozwiak kjozwiak merged commit efa63cc into 1.33.x Nov 26, 2021
@kjozwiak kjozwiak deleted the pr10760_referrer-onion-18071_1.33.x branch November 26, 2021 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@iefremov iefremov Awaiting requested review from iefremov iefremov is a code owner

Assignees

@fmarier fmarier

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @fmarier @brave-browser-releases