Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve query strings on IPFS redirect #10694

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Preserve query strings on IPFS redirect #10694

merged 1 commit into from
Jan 18, 2022

Conversation

iefremov
Copy link
Contributor

@iefremov iefremov commented Oct 26, 2021

From #10313:

When the setting Redirect IPFS resources to the configured IPFS gateway is on, previously query strings would not be preserved on the redirection. This PR fixes that and adds a test for this case. See linked issue for a full example and real world test case.

Resolves brave/brave-browser#18367

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

+Adds test to make sure query string is preserved
@iefremov
Copy link
Contributor Author

@DAlperin This is a fixed version of your PR #10313
There was an UAF problem with StringPiece that I fixed once I figure out that the test is flaky (thanks for writing the test), also I've fixed a couple of linting issues.

Are you ok with merging this PR or you can pick up changes and we can merge it from you fork?

@iefremov iefremov merged commit c650cee into master Jan 18, 2022
@iefremov iefremov deleted the ipfs_query branch January 18, 2022 14:17
@iefremov iefremov added this to the 1.36.x - Nightly milestone Jan 18, 2022
@markg85
Copy link

markg85 commented Jan 18, 2022

Nice! Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPFS redirect to localhost doesn't preserve query parameters
4 participants