Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave asks the user to paste from their clipboard when typing with the Kana Japanese keyboard #42526

Open
3 of 5 tasks
kylehickinson opened this issue Nov 26, 2024 · 0 comments · May be fixed by brave/brave-core#27212
Open
3 of 5 tasks
Assignees
Labels
OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/include

Comments

@kylehickinson
Copy link
Collaborator

Description

When using a Japanese (Kana) keyboard the user is repeatedly asked to paste contents from their clipboard while typing in the URL bar

Steps to reproduce

  1. Prefix: Copy some text into your clipboard from anywhere, add the Kana Japanese keyboard to your list of keyboards (Settings > General > Keyboards)
  2. Fresh install Brave
  3. Tap on the URL bar and switch the keyboard to the Japanese keyboard
  4. Type a few characters then tap 確定 (bottom right key)

Actual result

Brave attempts to check the pasteboard and shows the alert that asks the user if they'd like to paste

Expected result

Brave shouldn't check the pasteboard without the user performing an action

Reproduces how often

Easily reproduced

Brave version

1.71+

Device/iOS version

N/A

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

This is a regression caused by brave/brave-core#24376 due to function call to shouldShowSearchSuggestions(using:) making an assumption that the last replacement character will always be a single character if not pasting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant