Skip to content

Commit

Permalink
Disables blink::features::kTextFragmentAnchor
Browse files Browse the repository at this point in the history
Fixes brave/brave-browser#8342

Chromium change:

https://chromium.googlesource.com/chromium/src/+/62f8d5f096b174d05cd7f716585983df483024d7

commit 62f8d5f096b174d05cd7f716585983df483024d7
Author: Nick Burris <[email protected]>
Date:   Thu Jan 16 22:54:51 2020 +0000

    Enable Scroll To Text by default

    Enables scroll to text by default for M81. Note we plan to launch via
    Finch for M80.

    Intent to ship with LGTMs:
    https://groups.google.com/a/chromium.org/d/msg/blink-dev/zlLSxQ9BA8Y/t-_3pAiSAwAJ

    This patch also updates web platform test expectations:
    - scroll-to-text-fragment.html now passes; it just needed an extra rAF
      for the fallback to element anchor behavior.
    - scroll-to-text-fragment-security.html has two expected failures, as
      they need to be updated to test cross-origin navigations. I'll make
      this change in a follow-up patch to close bug 1042311.

    Bug: 919204
  • Loading branch information
mkarolin committed Mar 17, 2020
1 parent 434665d commit b62a61f
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions app/brave_main_delegate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,7 @@ bool BraveMainDelegate::BasicStartupComplete(int* exit_code) {
// Disabled features.
const std::unordered_set<const char*> disabled_features = {
autofill::features::kAutofillServerCommunication.name,
blink::features::kTextFragmentAnchor.name,
features::kAllowPopupsDuringPageUnload.name,
features::kAudioServiceOutOfProcess.name,
features::kLookalikeUrlNavigationSuggestionsUI.name,
Expand Down
2 changes: 2 additions & 0 deletions app/brave_main_delegate_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include "content/public/common/web_preferences.h"
#include "gpu/config/gpu_finch_features.h"
#include "services/network/public/cpp/features.h"
#include "third_party/blink/public/common/features.h"

using BraveMainDelegateBrowserTest = InProcessBrowserTest;

Expand All @@ -42,6 +43,7 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisableHyperlinkAuditing) {
IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
const base::Feature* disabled_features[] = {
&autofill::features::kAutofillServerCommunication,
&blink::features::kTextFragmentAnchor,
&features::kAllowPopupsDuringPageUnload,
&features::kAudioServiceOutOfProcess,
&features::kNotificationTriggers,
Expand Down
1 change: 1 addition & 0 deletions test/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -737,6 +737,7 @@ test("brave_browser_tests") {
":brave_browser_tests_deps",
":browser_tests_runner",
"//testing/gmock",
"//third_party/blink/public/common",
]
# enable_plugins should be used here
if (!is_android) {
Expand Down

0 comments on commit b62a61f

Please sign in to comment.