-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade from Chromium 74.0.3729.131 to Chromium 75.0.3770.27 #4366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
28 tasks
bsclifton
changed the title
WIP: Upgrade from Chromium 74.0.3729.131 to Chromium 75.0.3770.27
Upgrade from Chromium 74.0.3729.131 to Chromium 75.0.3770.27
May 11, 2019
emerick
previously approved these changes
May 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
brave-builds
force-pushed
the
75.0.3770.27
branch
from
May 13, 2019 22:03
b313212
to
a965d36
Compare
brave-builds
force-pushed
the
75.0.3770.27
branch
from
May 14, 2019 20:44
1b9813e
to
83b0eec
Compare
md_extensions_strings.grdp was renamed to extensions_strings.grdp file_manager_strings.grdp was moved to //ui/chromeos - since it's chromeos specific, don't think we need to bother with it any more. Chromium changes: commit 7477b5d6bea903f7ae72d2a2f9483fdfa60a251d Author: dpapad <[email protected]> Date: Thu Apr 11 16:35:17 2019 +0000 Extensions cleanup: Remove "md_" prefix from md_extensions_strings.grdp. Bug: 887150 commit 4152f97874932fd5d423ee7d878ba156a40afc88 Author: Luciano Pacheco <[email protected]> Date: Fri Mar 15 21:34:26 2019 +0000 Move all Files app translations to //ui/chromeos/ Follow up from CL: 1476887 where we moved only 1 translation because it was after branch freeze. This CL moves all Files app translations to //ui/chromeos/ so it can be shared with //components/arc and //chromeos/components/drivefs.
emerick
approved these changes
May 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bsclifton
added a commit
that referenced
this pull request
May 15, 2019
Upgrade from Chromium 74.0.3729.131 to Chromium 75.0.3770.27
bsclifton
added a commit
that referenced
this pull request
May 15, 2019
Upgrade from Chromium 74.0.3729.131 to Chromium 75.0.3770.27
bsclifton
added a commit
that referenced
this pull request
May 16, 2019
Upgrade from Chromium 74.0.3729.131 to Chromium 75.0.3770.27
bsclifton
added a commit
that referenced
this pull request
May 17, 2019
Upgrade from Chromium 74.0.3729.131 to Chromium 75.0.3770.27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4333
Related PR: brave/brave-core#2401
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) ongit rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.