Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 74.0.3729.131 to Chromium 75.0.3770.27 #4366

Merged
merged 3 commits into from
May 15, 2019

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented May 8, 2019

Fix #4333
Related PR: brave/brave-core#2401

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bsclifton bsclifton self-assigned this May 8, 2019
@bsclifton bsclifton added this to the 0.67.x - Nightly milestone May 8, 2019
@bsclifton bsclifton changed the title WIP: Upgrade from Chromium 74.0.3729.131 to Chromium 75.0.3770.27 Upgrade from Chromium 74.0.3729.131 to Chromium 75.0.3770.27 May 11, 2019
emerick
emerick previously approved these changes May 11, 2019
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mkarolin and others added 3 commits May 15, 2019 08:55
md_extensions_strings.grdp was renamed to extensions_strings.grdp
file_manager_strings.grdp was moved to //ui/chromeos - since it's
chromeos specific, don't think we need to bother with it any more.

Chromium changes:

commit 7477b5d6bea903f7ae72d2a2f9483fdfa60a251d
Author: dpapad <[email protected]>
Date:   Thu Apr 11 16:35:17 2019 +0000

    Extensions cleanup: Remove "md_" prefix from md_extensions_strings.grdp.

    Bug: 887150

commit 4152f97874932fd5d423ee7d878ba156a40afc88
Author: Luciano Pacheco <[email protected]>
Date:   Fri Mar 15 21:34:26 2019 +0000

    Move all Files app translations to //ui/chromeos/

    Follow up from CL: 1476887 where we moved only 1 translation because it
    was after branch freeze.

    This CL moves all Files app translations to //ui/chromeos/ so it can be
    shared with //components/arc and //chromeos/components/drivefs.
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsclifton bsclifton merged commit 0b877f9 into master May 15, 2019
@bsclifton bsclifton deleted the 75.0.3770.27 branch May 15, 2019 16:13
bsclifton added a commit that referenced this pull request May 15, 2019
Upgrade from Chromium 74.0.3729.131 to Chromium 75.0.3770.27
bsclifton added a commit that referenced this pull request May 15, 2019
Upgrade from Chromium 74.0.3729.131 to Chromium 75.0.3770.27
bsclifton added a commit that referenced this pull request May 16, 2019
Upgrade from Chromium 74.0.3729.131 to Chromium 75.0.3770.27
bsclifton added a commit that referenced this pull request May 17, 2019
Upgrade from Chromium 74.0.3729.131 to Chromium 75.0.3770.27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 74.0.3729.131 to Chromium 75.0.3770.38
3 participants