Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsuccessful login to Binance Widget after creating a new account #9863

Closed
ryanml opened this issue May 20, 2020 · 2 comments · Fixed by brave/brave-core#5607
Closed

Unsuccessful login to Binance Widget after creating a new account #9863

ryanml opened this issue May 20, 2020 · 2 comments · Fixed by brave/brave-core#5607

Comments

@ryanml
Copy link
Contributor

ryanml commented May 20, 2020

Description

Additional cookies are expected when retrieving the access token after making a new account, current net code was disabling sending/saving of cookies

Steps to Reproduce

  1. Start Brave with a clean profile
  2. Go through the Binance widget connect flow, create a new account

Actual result:

You are redirected back to the new tab page, the authed view never shows

Expected result:

You should be logged in, just as you are when connecting with an existing account

Reproduces how often:

100%

@ryanml ryanml added this to the 1.11.x - Nightly milestone May 20, 2020
@ryanml ryanml self-assigned this May 20, 2020
ryanml added a commit to brave/brave-core that referenced this issue May 20, 2020
@ryanml ryanml added the QA/Yes label May 21, 2020
ryanml added a commit to brave/brave-core that referenced this issue May 21, 2020
bbondy pushed a commit to brave/brave-core that referenced this issue May 25, 2020
bbondy pushed a commit to brave/brave-core that referenced this issue May 25, 2020
bbondy added a commit to brave/brave-core that referenced this issue May 25, 2020
bbondy added a commit to brave/brave-core that referenced this issue May 25, 2020
@srirambv
Copy link
Contributor

Moving to 1.9.x as brave/brave-core#5651 is uplifted

@rebron rebron changed the title Binance Widget Auth not successful when connecting with a new account. Unsuccessful login to Binance Widget after creating a new account May 29, 2020
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS Linux
  • Verified creating a new account and connecting widget works in the first attempt
  • Verified on both clean and upgrade install

Verification passed on

Brave 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS macOS Version 10.15.4 (Build 19E287)
  • Verified creating a new account and connecting widget works in the first attempt
  • Verified on both clean and upgrade install

Verification passed on

Brave 1.9.76 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS Windows 10 OS Version 1809 (Build 17763.379)
  • Verified creating a new account and connecting widget works in the first attempt
  • Verified on both clean and upgrade install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment