Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P3A] Amend Brave.Core.WindowCount question #9676

Closed
mattmcalister opened this issue May 7, 2020 · 7 comments · Fixed by brave/brave-core#5508 or brave/brave-core#5528
Closed

[P3A] Amend Brave.Core.WindowCount question #9676

mattmcalister opened this issue May 7, 2020 · 7 comments · Fixed by brave/brave-core#5508 or brave/brave-core#5528

Comments

@mattmcalister
Copy link

mattmcalister commented May 7, 2020

Test plan

  1. Use build for a while (5-10 mins) with 1 window open (any platform)
  2. Look in brave://local-state/ for Brave.Core.WindowCount.2
  3. Value should be 1
  4. On macOS, have no windows open (Brave will remain open)
  5. Leave it open for 5-10 mins, so histogram records
  6. In the profile directory, open the local_state file
  7. Find the Brave.Core.WindowCount.2 value and it should be 0

Description

Need to understand number of users with 0 windows open separately from 1 window. New answers should be:

0) 0
1) 1
2) 2 to 5
3) 6 or more
@bsclifton bsclifton self-assigned this May 7, 2020
@fmarier
Copy link
Member

fmarier commented May 7, 2020

No difference from a data category point of view. 👍

@bsclifton
Copy link
Member

@mattmcalister is that correct? Answers being 0, 1, 1, and 2? (and not 0, 1, 2, 3)

@mattmcalister
Copy link
Author

@mattmcalister is that correct? Answers being 0, 1, 1, and 2? (and not 0, 1, 2, 3)

good catch. fixed

bsclifton added a commit to brave/brave-core that referenced this issue May 10, 2020
have Brave open with no windows open when this question runs.

Fixes brave/brave-browser#9676
@bsclifton bsclifton added this to the 1.10.x - Nightly milestone May 11, 2020
bsclifton added a commit to brave/brave-core that referenced this issue May 11, 2020
have Brave open with no windows open when this question runs.

Fixes brave/brave-browser#9676
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 13, 2020

@mattmcalister @bsclifton - Can we update the 3rd point to 3) 6 or more?

0) 0
1) 1
2) 2 to 5
3) 6 or more

Also, the response value is NOT updated immediately, it's taking ~ 4 mins to show the response value. Is this delay expected?

@bsclifton
Copy link
Member

@GeetaSarvadnya updated! 😄

About 4 minutes is OK - it does take a while to run. I was usually waiting 5-10 mins 😄

@bsclifton
Copy link
Member

Closing as I believe this is closed

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 18, 2020

Verification passed on


Brave | 1.9.70 Chromium: 81.0.4044.138 (Official Build) (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)


Verification passed on

Brave 1.9.70 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

Verification passed on

Brave 1.9.70 Chromium: 81.0.4044.138 (Official Build) (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{# 999}
OS macOS Version 10.15.4 (Build 19E287)
  • Verified test plan from issue description
  • Verified when a window is open for 5-10 mins value is set to 1

Screenshot 2020-05-19 at 10 55 40 a m

  • Verified when all windows are closed but app is running for 5-10 mins value is set to 0

Screenshot 2020-05-19 at 11 19 11 a m

@bsclifton bsclifton added the feature/new-metric Proposing a new metric for Privacy Preserving Product Analytics (P3A) label Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment