Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet activity - Monthly Statement #930

Closed
NejcZdovc opened this issue Sep 2, 2018 · 22 comments · Fixed by brave/brave-core#4279
Closed

Wallet activity - Monthly Statement #930

NejcZdovc opened this issue Sep 2, 2018 · 22 comments · Fixed by brave/brave-core#4279
Assignees
@NejcZdovc
Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.7.x - Release

Comments

@NejcZdovc
Copy link
Contributor

Implement wallet activity dialog that is triggered on rewards page in wallet section.
@NejcZdovc NejcZdovc added this to the Releasable builds 0.55.x milestone Sep 2, 2018
@NejcZdovc
Copy link
Contributor Author

blocked on #918

@NejcZdovc NejcZdovc self-assigned this Sep 5, 2018
@bbondy bbondy added the QA/Yes label Oct 10, 2018
NejcZdovc added a commit to brave/brave-core that referenced this issue Oct 15, 2018
@NejcZdovc
Adds wallet activity
853ee0c 
Resolves brave/brave-browser#930
Resolves brave/brave-browser#1298
@NejcZdovc NejcZdovc mentioned this issue Oct 15, 2018
Closed
18 tasks
@NejcZdovc NejcZdovc modified the milestones: 0.55.x, 0.56.x Oct 16, 2018
@NejcZdovc NejcZdovc modified the milestones: 1.0, 0.56.x - Beta Oct 22, 2018
@mandar-brave
Copy link

Please fix #1298; closing #1298 as redundant

@mandar-brave mandar-brave mentioned this issue Oct 26, 2018
Closed
@bbondy bbondy modified the milestones: 0.57.x - Dev, 1.x Backlog Oct 30, 2018
@Miyayes
Copy link
Collaborator

Miyayes commented Sep 2, 2019

+1 https://www.reddit.com/r/BATProject/comments/cyg21b/history_for_previous_months_tips/

@NejcZdovc
Copy link
Contributor Author

blocked on #5815

@NejcZdovc NejcZdovc self-assigned this Dec 5, 2019
@NejcZdovc NejcZdovc added priority/P1 A very extremely bad problem. We might push a hotfix for it. and removed priority/P3 The next thing for us to work on. It'll ride the trains. blocked labels Dec 5, 2019
@NejcZdovc NejcZdovc mentioned this issue Dec 18, 2019
Closed
@cryptojennie
Copy link

+1 https://www.reddit.com/r/BATProject/comments/ezvygr/view_historical_monthbymonth_rewards/

@NejcZdovc NejcZdovc added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Feb 10, 2020
@NejcZdovc NejcZdovc mentioned this issue Mar 4, 2020
Merged
32 tasks
@NejcZdovc NejcZdovc added this to the 1.7.x - Nightly milestone Mar 6, 2020
@LaurenWags
Copy link
Member

marking as QA/Blocked until #8828 is uplifted to 1.7.x

@LaurenWags
Copy link
Member

LaurenWags commented Mar 31, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave 1.7.79 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)

  1. Clean profile 1.7.x (funded via UGP & Ad grants) - PASS

    • claim Ad grant
    • claim UGP grant
    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
      ---> Monthly statement contains all expected information

  2. Clean profile 1.7.x (funded via KYC'd wallet) - PASS

    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
      ---> Monthly statement contains all expected information

  3. Clean profile 1.7.x (funded via restored wallet with user funds) - PASS

    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
      ---> Monthly statement contains all expected information

  4. Upgrade - install 1.5.x (funded via UGP & Ad grants) - PASS

    • claim Ad grant
    • claim UGP grant
    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
    • upgrade to 1.7.x
    • view monthly statement
      ---> Monthly statement contains all expected information

  5. Upgrade - install 1.5.x (funded via KYC'd wallet) - PASS

    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
    • upgrade to 1.7.x
    • view monthly statement
      ---> Monthly statement contains all expected information

  6. Upgrade - install 1.5.x (funded via restored wallet with user funds) - PASS

    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
    • upgrade to 1.7.x
    • view monthly statement
      ---> Monthly statement contains all expected information

Screen Shot 2020-03-31 at 1 49 24 PM

Screen Shot 2020-03-31 at 1 49 33 PM

Screen Shot 2020-03-31 at 1 49 41 PM

Screen Shot 2020-03-31 at 1 49 49 PM

Verification is in-progress

Brave 1.7.81 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

  • General cases executed:
  1. Clean profile 1.7.x (funded via UGP & Ad grants) - PASS
    • claim UGP grant
    • claim Ad grant
    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips

---> Monthly statement contains all expected information - logged #8963
image

  1. Clean profile 1.7.x (funded via KYC'd wallet) - PASS
    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips

---> Monthly statement contains all expected information - Logged #8963

  1. Clean profile 1.7.x (funded via restored wallet with user funds) - PASS
    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips

---> Monthly statement contains all expected information
image

  1. Upgrade - install 1.5.x (funded via UGP & Ad grants) - PASS
    • claim Ad grant
    • claim UGP grant
    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
    • upgrade to 1.7.x
    • view monthly statement

---> Monthly statement contains all expected information
image

  1. Upgrade - install 1.5.x (funded via KYC'd wallet) - PASS
    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
    • upgrade to 1.7.x
    • view monthly statement

---> Monthly statement contains all expected information Encountered #8963
image

  1. Upgrade - install 1.5.x (funded via restored wallet with user funds) - PASS
    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
    • upgrade to 1.7.x
    • view monthly statement

---> Monthly statement contains all expected information

Verification passed on

Brave 1.7.82 Chromium: 80.0.3987.162 (Official Build) dev (64-bit)
Revision f2c5dd6138153bb0658091205bd1a1717f16081a-refs/branch-heads/3987@{#1034}
OS Ubuntu 18.04 LTS

  1. Clean profile 1.7.x (funded via UGP & Ad grants) - PASS

    • claim Ad grant
    • claim UGP grant
    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
      ---> Monthly statement contains all expected information

  2. Clean profile 1.7.x (funded via KYC'd wallet) - PASS

    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
      ---> Monthly statement contains all expected information

  3. Clean profile 1.7.x (funded via restored wallet with user funds) - PASS

    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
      ---> Monthly statement contains all expected information

  4. Upgrade - install 1.5.x (funded via UGP & Ad grants) - PASS

    • claim Ad grant
    • claim UGP grant
    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
    • upgrade to 1.7.x
    • view monthly statement
      ---> Monthly statement contains all expected information

  5. Upgrade - install 1.5.x (funded via KYC'd wallet) - PASS

    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
    • upgrade to 1.7.x
    • view monthly statement
      ---> Monthly statement contains all expected information

  6. Upgrade - install 1.5.x (funded via restored wallet with user funds) - PASS

    • set up & perform AC
    • set up & perform recurring tips
    • set up 1 time tips
    • upgrade to 1.7.x
    • view monthly statement

image
image
image
image

@kjozwiak kjozwiak mentioned this issue Apr 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.7.x - Release