Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change publisher list fetch interval #8955

Closed
NejcZdovc opened this issue Apr 1, 2020 · 1 comment · Fixed by brave/brave-core#5129
Closed

Change publisher list fetch interval #8955

NejcZdovc opened this issue Apr 1, 2020 · 1 comment · Fixed by brave/brave-core#5129

Comments

@NejcZdovc
Copy link
Contributor

We should change interval of refreshing publisher list from 1 day to 3 days.

@srirambv
Copy link
Contributor

srirambv commented Apr 3, 2020

Verification passed on

Brave 1.7.85 Chromium: 80.0.3987.162 (Official Build) dev (64-bit)
Revision f2c5dd6138153bb0658091205bd1a1717f16081a-refs/branch-heads/3987@{#1034}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified Publisher list was downloaded into server_publisher_info table on clean profile launch
  • Verified no publisher list is downloaded when server_publisher_list_stamp is set to 1585831908
  • Verified Publisher list is downloaded when server_publisher_list_stamp is set to 1585659591
[ RESPONSE - OnDownload ]
> time: 1585659591
> result: Success
> http code: 200
> response: Publisher list
> headers accept-ranges: bytes
> headers access-control-allow-headers: Origin, X-Requested-With, Content-Type, Accept, Authorization
> headers access-control-allow-methods: GET
> headers access-control-allow-origin: https://rewards.bravesoftware.com
> headers access-control-request-method: GET
> headers age: 809
> headers cache-control: max-age=3600, public
> headers content-encoding: gzip
> headers content-length: 16988563
> headers content-type: application/json; charset=utf-8
> headers date: Fri, 03 Apr 2020 12:31:47 GMT
> headers etag: W/"895389a2363c43f0775c5b60424864bc"
> headers server: Cowboy
> headers status: 200
> headers vary: Accept-Encoding
> headers via: 1.1 varnish
> headers x-cache: HIT
> headers x-cache-hits: 0
> headers x-frame-options: deny
> headers x-request-id: b098b44f-9e22-40da-a11a-dbac7a8a20b5
> headers x-runtime: 1.703006
> headers x-served-by: cache-bom18220-BOM
[ END RESPONSE ]

Verified passed with

Brave 1.7.85 Chromium: 80.0.3987.162 (Official Build) dev (64-bit)
Revision f2c5dd6138153bb0658091205bd1a1717f16081a-refs/branch-heads/3987@{#1034}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified test plan from Change publisher list interval from 1 to 3 days brave-core#5129
  • Confirmed publisher list downloaded by checking server_publisher_info table in publisher_info_db
  • Confirmed updating server_publisher_list_stamp to be one day in the past does not trigger re-download
  • Confirmed updating server_publisher_list_stamp to be 3 days in the past does trigger re-download of catalog
[ RESPONSE - OnDownload ]
> time: 1585927772
> result: Success
> http code: 200
> response: Publisher list
> headers accept-ranges: bytes
> headers access-control-allow-headers: Origin, X-Requested-With, Content-Type, Accept, Authorization
> headers access-control-allow-methods: GET
> headers access-control-allow-origin: https://rewards.bravesoftware.com
> headers access-control-request-method: GET
> headers age: 2133
> headers cache-control: max-age=3600, public
> headers content-encoding: gzip
> headers content-length: 16998257
> headers content-type: application/json; charset=utf-8
> headers date: Fri, 03 Apr 2020 15:23:31 GMT
> headers etag: W/"f3d63efd4525411d7142dd37bb989c95"
> headers server: Cowboy
> headers status: 200
> headers vary: Accept-Encoding
> headers via: 1.1 varnish
> headers x-cache: HIT
> headers x-cache-hits: 0
> headers x-frame-options: deny
> headers x-request-id: 9d7b3055-4bda-4c66-a612-bdb322e8c7ce
> headers x-runtime: 1.937346
> headers x-served-by: cache-ewr18135-EWR
[ END RESPONSE ]

Verification passed on

Brave 1.7.86 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS Ubuntu 18.04 LTS
  • Verified test plan from Change publisher list interval from 1 to 3 days brave-core#5129
  • Confirmed publisher list downloaded by checking server_publisher_info table in publisher_info_db
  • Confirmed updating server_publisher_list_stamp to be one day in the past does not trigger re-download
  • Confirmed updating server_publisher_list_stamp to be 3 days in the past does trigger re-download of catalog
[14220:14220:0406/235854.592186:VERBOSE1:ledger_impl.cc(943)] 
[ RESPONSE - OnDownload ]
> time: 1586210334
> result: Success
> http code: 200
> response: Publisher list
> headers accept-ranges: bytes
> headers access-control-allow-headers: Origin, X-Requested-With, Content-Type, Accept, Authorization
> headers access-control-allow-methods: GET
> headers access-control-allow-origin: https://rewards.bravesoftware.com
> headers access-control-request-method: GET
> headers age: 2960
> headers cache-control: max-age=3600, public
> headers content-encoding: gzip
> headers content-length: 17167244
> headers content-type: application/json; charset=utf-8
> headers date: Mon, 06 Apr 2020 21:52:26 GMT
> headers etag: W/"643c77ccf88751f03deb7ce676c6a630"
> headers server: Cowboy
> headers status: 200
> headers vary: Accept-Encoding
> headers via: 1.1 varnish
> headers x-cache: HIT
> headers x-cache-hits: 0
> headers x-frame-options: deny
> headers x-request-id: 32ff7bb5-3d6f-497c-89f6-b0bac76e0d37
> headers x-runtime: 2.180406
> headers x-served-by: cache-lga21983-LGA
[ END RESPONSE ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment