-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension import follow up (import extension settings) #8847
Comments
Verification
|
Brave | 1.45.84 Chromium: 106.0.5249.91 (Official Build) beta (x86_64) |
---|---|
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707} |
OS | macOS Version 11.7 (Build 20G817) |
Steps:
- launched
Google Chrome
(105.0.5195.125
) - loaded
https://metamask.io/download/
- clicked
Install MetaMask for Chrome
- clicked on
Add to Chrome
- clicked on the
Add extension
button - clicked on
Get started
within theMetaMask
UI - clicked
No thanks
- clicked
Create a wallet
- pasted generated password
- clicked
Create...
- shut down
Google Chrome
- launched
Brave
- clicked on
Let's go
- clicked on
Import from...
- chose
Chrome Person 1
- clicked
Import
- clicked
Done
- pasted the same password
- clicked on
Unlock
Confirmed I could successfully open my Metamask
wallet imported from Chrome
wallet (Chrome) | re-auth screen | wallet (Brave) |
---|---|---|
Verification
Steps:
Confirmed successfully logged in to
|
wallet (Chrome) | re-auth screen | wallet (Brave) | Extension |
---|---|---|---|
Verification passed on
Brave | 1.45.90 Chromium: 106.0.5249.103 (Official Build) beta (64-bit) |
---|---|
Revision | 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6} |
OS | Ubuntu 18.04 LTS |
Hi folks, I can't get extension settings import to work on Brave. I tried following the steps on #8847 (comment) with source Chrome version 125.0.6422.142 and target Brave versions 1.67.115 Chromium: 126.0.6478.56 as well as 1.68.87 Chromium: 126.0.6478.56. I'm on macOS arm64. In every test I did the extensions themselves were imported into Brave, but the settings did not carry over i.e. MetaMask did not give me the "Welcome back!" screen. I also tested uBO and did not see the custom filters get carried over. |
Test plan
See brave/brave-core#14997
Description
Follow up to #7974
With brave/brave-core#4672, ability to import extensions from Chrome is possible. The state of the extensions is not imported though.
Steps to Reproduce
Actual result:
State of extension is not imported
Expected result:
State of extension should be imported
cc: @rebron @simonhong
The text was updated successfully, but these errors were encountered: