Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension import follow up (import extension settings) #8847

Closed
bsclifton opened this issue Mar 24, 2020 · 3 comments · Fixed by brave/brave-core#14997
Closed

Extension import follow up (import extension settings) #8847

bsclifton opened this issue Mar 24, 2020 · 3 comments · Fixed by brave/brave-core#14997

Comments

@bsclifton
Copy link
Member

bsclifton commented Mar 24, 2020

Test plan

See brave/brave-core#14997

Description

Follow up to #7974

With brave/brave-core#4672, ability to import extensions from Chrome is possible. The state of the extensions is not imported though.

Steps to Reproduce

  1. Have an install of Chrome
  2. Install an extension that has state; ex: Metamask
  3. Use Brave's import functionality (added with Import chrome extension list brave-core#4672)

Actual result:

State of extension is not imported

Expected result:

State of extension should be imported

cc: @rebron @simonhong

@stephendonner
Copy link

stephendonner commented Oct 3, 2022

Verification PASSED using

Brave 1.45.84 Chromium: 106.0.5249.91 (Official Build) beta (x86_64)
Revision fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS macOS Version 11.7 (Build 20G817)

Steps:

  1. launched Google Chrome (105.0.5195.125)
  2. loaded https://metamask.io/download/
  3. clicked Install MetaMask for Chrome
  4. clicked on Add to Chrome
  5. clicked on the Add extension button
  6. clicked on Get started within the MetaMask UI
  7. clicked No thanks
  8. clicked Create a wallet
  9. pasted generated password
  10. clicked Create...
  11. shut down Google Chrome
  12. launched Brave
  13. clicked on Let's go
  14. clicked on Import from...
  15. chose Chrome Person 1
  16. clicked Import
  17. clicked Done
  18. pasted the same password
  19. clicked on Unlock

Confirmed I could successfully open my Metamask wallet imported from Chrome

wallet (Chrome) re-auth screen wallet (Brave)
Screen Shot 2022-10-03 at 4 32 20 PM Screen Shot 2022-10-03 at 4 37 29 PM Screen Shot 2022-10-03 at 4 37 37 PM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 3, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Oct 3, 2022

Verification PASSED using

Brave | 1.45.84 Chromium: 106.0.5249.91 (Official Build) beta (64-bit)
-- | --
Revision | fa96d5f07b1177d1bf5009f647a5b8c629762157-refs/branch-heads/5249@{#707}
OS | Windows 11 Version 21H2 (Build 22000.978)

Steps:

  1. launched Google Chrome (105.0.5195.127)
  2. visit chrome.google.com/webstore and search for metamask
  3. click the MetaMask extension and click Add to Chrome button
  4. clicked on Add to Chrome
  5. clicked on the Add extension button
  6. clicked on Get started within the MetaMask UI
  7. clicked No thanks
  8. clicked Create a wallet
  9. pasted generated password
  10. clicked Create...
  11. shut down Google Chrome
  12. launched Brave
  13. clicked on Let's go
  14. clicked on Import from...
  15. chose Chrome Person 1
  16. clicked Import
  17. clicked Done
  18. pasted the same password for MetaMask
  19. clicked on Unlock

Confirmed successfully logged in to Metamask wallet imported from Chrome

wallet (Chrome) re-auth screen wallet (Brave) Extension
image image image image

Verification passed on

Brave 1.45.90 Chromium: 106.0.5249.103 (Official Build) beta (64-bit)
Revision 182570408a1f25ab2731ef5f283b918df9b9f956-refs/branch-heads/5249_91@{#6}
OS Ubuntu 18.04 LTS

chrome - metamask
image

brave - metamask
image

brave - metamask - logged in
image

@ShivanKaul
Copy link
Collaborator

Hi folks, I can't get extension settings import to work on Brave. I tried following the steps on #8847 (comment) with source Chrome version 125.0.6422.142 and target Brave versions 1.67.115 Chromium: 126.0.6478.56 as well as 1.68.87 Chromium: 126.0.6478.56. I'm on macOS arm64.

In every test I did the extensions themselves were imported into Brave, but the settings did not carry over i.e. MetaMask did not give me the "Welcome back!" screen. I also tested uBO and did not see the custom filters get carried over.
Is this a regression?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment