Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Site Settings to Site and Shields Settings in #8826

Closed
simonhong opened this issue Mar 24, 2020 · 1 comment · Fixed by brave/brave-core#4624
Closed

Rename Site Settings to Site and Shields Settings in #8826

simonhong opened this issue Mar 24, 2020 · 1 comment · Fixed by brave/brave-core#4624

Comments

@simonhong
Copy link
Member

Shields settings are subset in Site settings.
So, Site Settings in settings page is renamed to Site and Shields Settings.

In brave://settings/privacy and Clear browsing data dialog, all the Site Settings title is renamed.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 24, 2020

Verification passed on

Brave 1.7.67 Chromium: 80.0.3987.149 (Official Build) beta (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified that Site Settings in settings page is renamed to Site and Shields Settings.
    image
  • Verified that Site Settings is renamed to Site and Shields Settings in clear browsing data dialog
    image

Verification PASSED on macOS 10.15.3 x64 using the following build:

Brave | 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | macOS Version 10.15.3 (Build 19D76)

Screen Shot 2020-03-24 at 11 33 51 AM

Screen Shot 2020-03-24 at 11 34 14 AM

Screen Shot 2020-03-24 at 11 36 11 AM

Verification passed on

Brave 1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS Ubuntu 18.04 LTS

image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment