Clearing Shields Per-Site Settings

[tildelowengrimm]

None of the options in the "Clear Browsing Data" settings item explicitly call out Shields, but certainly some of them affect Shields, because I just restarted my browser with some of them selected and my per-site and global Shields settings were reset.

We should specifically call out Shields settings in the clear-on-exit menu.

[sbtnc]

Yes, indeed. When "Site Settings" is checked in "Clear browsing data", it causes a reset on some (not all) shields settings.

Maybe "Site Settings" label is misleading (as I would expect specifics settings not global ones) or it's a bug.

For my case, I have a privacy oriented profile for daily surfing (whitelisting approach). Thus clearing all browsing data on exit does make sense. However, defaults shields settings get reseted on restart which are least private settings.

Steps to Reproduce

1. In "Settings" > "Brave shields default" set to non defaults "Ad Control", "Cookie Control" and "Fingerprinting protection";
2. In "Settings" > "Clear browsing data" > "On exit" check "Site Settings";
3. Restart Brave Browser;

Actual result:

Global settings are back to defaults.

Expected result:

Global settings don't get back to defaults.

Reproduces how often:

Always.

Brave version

Brave	0.64.77 Chromium: 74.0.3729.169 (Official Build) (64-bit)
Revision	78e4f8db3ce38f6c26cf56eed7ae9b331fc67ada-refs/branch-heads/3729@{#1013}
OS	Mac OS X

[rebron]

@tomlowenthal Fixed with #8826?