Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete icon in cookie settings does not delete some entries set from Shields or other settings #8604

Closed
keeganwitt opened this issue Mar 10, 2020 · 13 comments · Fixed by brave/brave-core#13126
Closed

Delete icon in cookie settings does not delete some entries set from Shields or other settings #8604

keeganwitt opened this issue Mar 10, 2020 · 13 comments · Fixed by brave/brave-core#13126
Assignees
@boocmp
Labels
feature/cookie-allow-list feature/cookies feature/shields The overall Shields feature in Brave. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.42.x - Release

Comments

@keeganwitt
Copy link

keeganwitt commented Mar 10, 2020 •
edited
Loading

Description

Delete button on brave://settings/content/cookies (under "allow", which shows sites where the shield has been turned off), clicking the trash icon appears to do nothing.

Steps to Reproduce

  1. Go to a site, bring the shield down for that site.
  2. Go to brave://settings/content/cookies
  3. Click the trash icon next to the allowed site.

Actual result:

Nothing happens.

Expected result:

Shields are brought back up for that site.

Reproduces how often:

Every time.

Brave version (brave://version info)

1.6.59

Version/Channel Information:

  • Can you reproduce this issue with the current release? Unknown
  • Can you reproduce this issue with the beta channel? Unknown
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Unknown

If this is an incompletely delivered feature, feel free to let me know and close this issue.
@danielegrattarola
Copy link

I have the same issue:

Version 1.7.92
Chromium: 80.0.3987.163 (Official Build) (64-bit)
Linux Ubuntu 16.04.02

There are a bunch of whitelisted websites that I visited a long time ago that don't get cleared when I manually delete cookies.

@rebron rebron added feature/cookies feature/shields The overall Shields feature in Brave. and removed feature/cookies labels May 1, 2020
@rebron
Copy link
Collaborator

rebron commented May 1, 2020

cc: @tomlowenthal Can you take a look at this one? Toggling anything in here brave://settings/content/cookies shouldn't reset shields settings status up or down.

@tildelowengrimm
Copy link
Contributor

@rebron Not sure I follow. The issue definitely deems valid: the delete button next to those items doesn't work. Why shouldn't it?

@rebron
Copy link
Collaborator

rebron commented May 1, 2020

@tomlowenthal You're right, I misread the issue. Expected result is site is deleted from the allowed list.

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 1, 2020
@dentistformyeye dentistformyeye mentioned this issue Jul 2, 2020
Closed
@dentistformyeye
Copy link

Also happens with the Block list. Manually created entries in the cookie settings have a menu with a Remove option that works normally, so the Clear On Exit list shouldn't be affected.

@dentistformyeye dentistformyeye mentioned this issue Aug 18, 2020
Closed
@rebron rebron mentioned this issue May 28, 2021
Open
6 tasks
@boocmp boocmp mentioned this issue Apr 25, 2022
Merged
25 tasks
@boocmp boocmp added this to the 1.42.x - Nightly milestone Jun 21, 2022
@rebron rebron changed the title Delete icon in cookie settings does nothing Delete icon in cookie settings does not delete some entries set from Shields or other settings Jun 21, 2022
@boocmp boocmp added OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 30, 2022
@MadhaviSeelam
Copy link

MadhaviSeelam commented Jul 11, 2022 •
edited
Loading

Verification Complete using

Brave | 1.42.61 Chromium: 103.0.5060.114 (Official Build) beta (64-bit)
-- | --
Revision | a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS | Windows 11 Version 21H2 (Build 22000.739)

Reproduced the issue in 1.41.95 using STR from #8604 (comment)

2022-07-12_13h28_17

Filed ##24106

Case 1: Set to Allow all cookies in brave://settings/cookies - Passed

  1. Install 1.42.61
  2. Launch Brave
  3. Open brave://settings/cookies
  4. Select Allow all cookies
  5. Visit www.whatismybrowser.com site
  6. Click Shields icon>>Advanced Controls
  7. Verified Allow all cookies is selected
  8. Open dev tools in the site to verify all cookies shown
  9. Visit brave://settings/shields and verify Disabled selected - settings matched to brave://settings/cookies page
  10. Open brave://settings/siteData and verify all cookies shown
Step 4 Step 7 Step8 Step 9 Site 10
image image image image image

Case 2: Set to Block Third-party cookies in brave://settings/cookies - Passed

  1. Continue from Case 1
  2. Select Block Third-party cookies in brave://settings/cookies
  3. Visit www.whatismybrowser.com site
  4. Verified Block cross-site cookies is selected in the Shields panel
  5. Visit brave://settings/shields and verify Only cross-site is selected
  6. Load whatismybrowser.com site
  7. Verified no 3rd party cookies shown in the dev tools
  8. Verified no '3rd party cookies` shown in brave://settings/siteData
Step 2 Step 4 Step 5 Step 7 Step 8
image image image image image

Case 3: Set to Block all cookies in brave://settings/cookies - Passed

  1. Continue from Case 2
  2. Select Block all cookies
  3. Visit www.whatismybrowser.com site
  4. Click Shields icon>>Advanced Controls
  5. Verified Block all cookies is selected
  6. Visit brave://settings/shields and verify All is selected
  7. Return to whatismybrowser.com site
  8. Clear cookies in dev tools and reload the site
  9. Verified no cookies shown in the dev tools
  10. Verified no cookies shown in brave://settings/siteData for the site
Step 2 Step 5 Step6 Step 9 Step 10
image image image image image

Case 4: Set to Allow all cookies while Shields DOWN - Passed

  1. New profile
  2. Launch Brave
  3. Open brave://settings/cookies and select Allow all cookies
  4. Visit www.whatismybrowser.com site
  5. Click Shields icon and turn shields DOWN
  6. Visit brave://settings/shields and verified Disabled is selected to match to brave://settings/cookies
  7. Return to www.whatismybrowser.com to verify all cookies shown in the dev tools
  8. Verified www.whatismybrowser.com site entry is shown in the Sites that can always use cookies in brave://settings/cookies
  9. Verified www.whatismybrowser.com entry cannot be removed by clicking the trash icon
Step 3 Step 5 Step 6 Step 7 Step 8
image image image image image

Case 5: Set to Block all cookies in the Shields panel - Passed

  1. Continue from Case 4:
    • Keep Allow all cookies in brave://settings/cookies
    • www.whatismybrowser.com site entry is still shown in the Sites that can always use cookies in brave://settings/cookies
  2. Visit www.whatismybrowser.com site
    • Click Shields icon and toggle ON for shields
    • Select Block all cookies in the Shields panel
  3. Visit brave://settings/shields and verify Disabled selected
  4. Return to www.whatismybrowser.com
  5. Clear cookies in dev tools and reload the site
  6. Verified no cookies shown in the dev tools
  7. Verified www.whatismybrowser.com site entry is shown in the Sites that can never use cookies in brave://settings/cookies
  8. Verified www.whatismybrowser.com site entry is removed in the Sites that can always use cookies in brave://settings/cookies
Step 1 Step 2 Step 3 Step 6 Step 7&8
image image image image image

Case 6: Set to Block cross-site cookies in Shields panel - Passed

  1. Continue from Case 5:
    • Keep Allow all cookies in brave://settings/cookies
    • www.whatismybrowser.com site entry is still shown in the Sites that can never use cookies in brave://settings/cookies
  2. Visit www.whatismybrowser.com site
    • Select Block cross-site cookies in the Shields panel
  3. Open brave://settings/shields and verify Disabled is selected to match to brave://settings/cookies
  4. Reload www.whatismybrowser.com site
  5. Verified no 3rd party cookies shown in the dev tools
  6. Verified [*.]whatismybrowser.com entry is shown in Sites than can always use cookies in brave://settings/cookies
Step 1 Step 2 Step 3 Step 5 Step 6
image image image image image

Case 7: Remove first party rule in brave://settings/cookies - Passed

  1. Continue from Case 6:
    • [*.]whatismybrowser.com entry is still listed in Sites than can always use cookies in brave://settings/cookies
    • Keep Allow all cookies in `brave://settings/cookies
    • www.whatismybrowser.com entry is still shown in the Sites that can always use cookies in brave://settings/cookies
  2. Click trash icon next to [*.]whatismybrowser.com to delete the entry in Sites that can always use cookies
  3. Return to www.whatismybrowser.com site and verify Shield settings changed to Block all cookies
  4. Clear cookies in dev tools and reload the site
  5. Verified no cookies shown in the dev tools
Step 1 Step 2 Step 3 Step 5
image image image image

Case 8: Remove block rule in brave://settings/cookies - Passed

  1. Continue from Case 7:
    • www.whatismybrowser.com entry is still listed in Sites that can never use cookies in brave://settings/cookies
    • Keep Allow all cookies in brave://settings/cookies
    • Shields panel shows Block all cookies setting
  2. Click trash icon next to www.whatismybrowser.com to delete the entry in Sites that can never use cookies
  3. Return to www.whatismybrowser.com site and verify Shield settings changed to Allow all cookies
  4. Reload the site
  5. Verified all cookies shown in the dev tools
Step 1 Step 2 Step 3 Step 4
image image image image

Case 9: Change to default setting, Block third-party cookies in brave://settings/cookies - Passed

  1. Continue from Case 8:
    • Allow all cookies in brave://settings/cookies is already selected
  2. Select default setting of Block third-party cookies in brave://settings/cookies
  3. Return to www.whatismybrowser.com site and verify Shield settings changed to Block cross-site cookies
  4. Open brave://settings/shields and verified Only cross-site selected
  5. Return to www.whatismybrowser.com site
  6. Clear cookies in dev tools and reload the site
  7. Verified no 3rd party cookies shown in the dev tools
Step 1 Step 2 Step 3 Step 4 Step 7
image image image image image

Case 10: Manually add allow all rule in brave://settings/cookies - Passed

  1. Continue from Case 9
    • Keep default setting of Block third-party cookies in brave://settings/cookies
    • Shields panel shows Block cross-site cookies setting
  2. Manually add www.whatismybrowser.com in Sites than can always use cookies in brave://settings/cookies
  3. Check the check box of Including third-party cookies on this site
  4. Return to www.whatismybrowser.com site and verify Shield settings changed to Allow all cookies
  5. Block third-party cookies setting is still retained brave://settings/cookies
  6. Clear cookies in dev tools and reload the site
  7. Verified all cookies shown in the dev tools including 3rd cookies
Step 1 Step 2 Step 4 Step 5 Step 7
image image image image image

Case 11: Manually add allow all rule in brave://settings/cookies - do not check for 3rd party cookies - Passed

  1. Continue from Case 10
    • Keep default setting of Block third-party cookies in brave://settings/cookies
    • Shields panel shows Block cross-site cookies setting
  2. Manually add www.whatismybrowser.com in Sites than can always use cookies in brave://settings/cookies
  3. Do not check the check box for Including third-party cookies on this site
  4. Return to www.whatismybrowser.com site and verify Shield settings changed to Allow all cookies
  5. Block third-party cookies setting is still retained brave://settings/cookies
  6. Clear cookies in dev tools and reload the site
  7. Verified 3rd party cookies not shown in the dev tools
Step 1 Step 2 & 3 Step 4 Step5 Step7
image image image image image

Case 12: Manually remove allow all and add block all in brave://settings/cookies - Passed

  1. Continue from Case 11
    • Keep default setting of Block third-party cookies in brave://settings/cookies
    • www.whatismybrowser.com entry is still listed Sites than can always use cookies in brave://settings/cookies
    • Shields panel in whatismybrowser.com still shows Allow all cookies setting
  2. open brave://settings/cookies and click trash icon to delete the www.whatismybrowser.com from Sites than can always use cookies
  3. Add www.whatismybrowser.com in Sites that can never use cookies in brave://settings/cookies
  4. Return to www.whatismybrowser.com site and verify Shield settings changed to Block all cookies
  5. Clear cookies in dev tools and reload the site
  6. Verified no cookies shown in the dev tools
Step 1 Step 2 Step 3 Step4 Step 6
image image image image image

Case 13: Disable Shields in the Shields panel - Passed

  1. Continue from Case 12
    • Keep default setting of Block third-party cookies in brave://settings/cookies
    • www.whatismybrowser.com is still listed in Sites that can never use cookies in brave://settings/cookies
  2. Return to www.whatismybrowser.com site and turn shields DOWN in the Shields panel
  3. Verified www.whatismybrowser.com entry is added to Sites than can always use cookies in brave://settings/cookies
  4. When Allow all rule is added in Step 3 when Shields was disabled, 'www.whatismybrowser.com' is hidden in Sites that can never use cookies section
  5. Confirmed www.whatismybrowser.com entry cannot be deleted when clicked on delete icon
  6. Return to www.whatismybrowser.com site and clear cookies in dev tools and reload the site
  7. Verified all cookies shown in the dev tools
Step 1 Step 2 Step 3& 4 Step 8
image image image image

Case 14: Enable Shields in the Shields panel - Passed

  1. Continue from Case 13
    • Keep default setting of Block third-party cookies in brave://settings/cookies
    • www.whatismybrowser.com is still listed in Sites that can never use cookies in brave://settings/cookies
    • Shields DOWN for www.whatismybrowser.com site in the Shields panel
    • www.whatismybrowser.com entry is available Sites than can always use cookies in brave://settings/cookies
  2. Return to www.whatismybrowser.com site and enable Shields
  3. Block all cookies setting is retained in the Shields panel
  4. www.whatismybrowser.com entry is removed from Sites than can always use cookies in brave://settings/cookies
  5. www.whatismybrowser.com is shown in Sites that can never use cookies
  6. Clear cookies in dev tools and reload the site
  7. Verified all cookies shown in the dev tools
Step 1 Step 2&3 Step 4&5 Step 7
image image image image

Case 15: Change to Block cross-site cookies in the Shields panel - Passed

  1. Continue from Case 14
    • Keep default setting of Block third-party cookies in brave://settings/cookies
    • www.whatismybrowser.com entry is shown in Sites that can never use cookies
  2. Return to www.whatismybrowser.com site and select Block cross-site cookies
  3. www.whatismybrowser.com entry is added to Sites than can always use cookies in brave://settings/cookies
  4. Clear cookies in dev tools and reload the site
  5. Verified no 3rd party cookies shown in the dev tools
Step 1 Step 3 Step 5
image image image

Case 16: Remove shields rules in brave://settings/cookies - Passed

  1. Continue from Case 15
    • Keep default setting of Block third-party cookies in brave://settings/cookies
    • www.whatismybrowser.com entry is shown in Sites that can never use cookies in brave://settings/cookies
    • www.whatismybrowser.com entry is shown in Sites than can always use cookies in brave://settings/cookies
    • Shields panel shows Block cross-site cookies for www.whatismybrowser.com
  2. Delete following in brave://settings/cookies
    • www.whatismybrowser.com entry is shown in Sites that can never use cookies
    • www.whatismybrowser.com entry is shown in Sites than can always use cookies
  3. Return to www.whatismybrowser.com and confirmed Shields panel shows Block cross-site cookies
  4. Clear cookies in dev tools and reload the site
  5. Verified no 3rd party cookies shown in the dev tools
Step 1A Step 1B Step 2 Step 3 Step 5
image image image image image

Case 17: Allow all cookies in brave://settings/cookies - Passed

  1. Select Allow all cookies in brave://settings/cookies
  2. Load www.whatismybrowser.com and click on the lock icon>>Cookies>>whatismybrowser.com>>Block>>Done
  3. Click Reload to reload the page
  4. Verified Shields panel shows Allow all cookies settings
  5. Confirmed www.whatismybrowser.com entry is added to Sites that can never use cookies
  6. Return to www.whatismybrowser.com site and reload the page
  7. Verified no 3rd party cookies shown in the dev tools
Step 1 Step 2 Step 3 Step 4 Step 5 Step 7
image image image image image image

Case 18: Shields Down in the Shields panel - Passed

  1. Keep Allow all cookies in brave://settings/cookies
  2. Return to www.whatismybrowser.com site
  3. Toggle OFF the shields in the Shields panel
  4. Verified no 3rd party cookies shown in the dev tools
Step 1 Step 2 Step 4
image image image

Case 19: Delete 3p rule from brave://settings/cookies - Passed

  1. Continue from Case 17
    • Keep Allow all cookies in brave://settings/cookies
    • www.whatismybrowser.com entry is still shown to Sites that can never use cookies
  2. Open brave://settings/cookies and remove www.whatismybrowser.com entry by clicking ellipsis>>Remove
  3. Return to the www.whatismybrowser.com site and clear cookies in dev tools and reload
  4. Verified all cookies shown in the dev tools
Step 1B Step 2 Step 4
image image image

@MadhaviSeelam MadhaviSeelam mentioned this issue Jul 18, 2022
Open
@LaurenWags
Copy link
Member

LaurenWags commented Jul 19, 2022 •
edited
Loading

Verified with

Brave | 1.42.74 Chromium: 103.0.5060.134 (Official Build) beta (x86_64)
-- | --
Revision | 8ec6fce403b3feb0869b0732eda8bd95011d333c-refs/branch-heads/5060@{#1262}
OS | macOS Version 12.4 (Build 21F79)

Case 1: Set to Allow all cookies in brave://settings/cookies - PASSED

  1. Install 1.42.x
  2. Launch Brave
  3. Open brave://settings/cookies
  4. Select Allow all cookies
  5. Visit https://www.whatismybrowser.com
  6. Click Shields icon>>Advanced Controls
  7. Verified Allow all cookies is selected
  8. Open dev tools in the site to verify all cookies shown
  9. Visit brave://settings/shields and verify Disabled selected - settings matched to brave://settings/cookies page
  10. Open brave://settings/siteData and verify all cookies shown
Step 4 Step 7 Step 8 Step 9 Step 10
4 7 8 9 10

Case 2: Set to Block Third-party cookies in brave://settings/cookies - PASSED

  1. Continue from case 1 and clear all cookies or do a new profile prior to doing the below steps
  2. Select Block Third-party cookies in brave://settings/cookies
  3. Visit https://www.whatismybrowser.com
  4. Verified Block cross-site cookies is selected in the Shields panel
  5. Visit brave://settings/shields and verify Only cross-site is selected
  6. Load https://www.whatismybrowser.com
  7. Verified no 3rd party cookies shown in the dev tools
  8. Verified no '3rd party cookies` shown in brave://settings/siteData
Step 2 Step 4 Step 5 Step 7 Step 8
2 4 5 7 8

Case 3: Set to Block all cookies in brave://settings/cookies - PASSED

  1. Continue from Case 2 and clear all cookies or do a new profile prior to doing the below steps
  2. Select Block all cookies in brave://settings/cookies
  3. Visit https://www.whatismybrowser.com
  4. Click Shields icon>>Advanced Controls
  5. Verified Block all cookies is selected
  6. Visit brave://settings/shields and verify All is selected
  7. Return to https://www.whatismybrowser.com
  8. Clear cookies in dev tools and reload the site
  9. Verified no cookies shown in the dev tools
  10. Verified no cookies shown in brave://settings/siteData for the site
Step 2 Step 5 Step 6 Step 9 Step 10
2 5 6 9 10

Case 4: Set to Allow all cookies then Shields DOWN - PASSED

  1. New profile
  2. Launch Brave
  3. Open brave://settings/cookies and select Allow all cookies
  4. Visit www.whatismybrowser.com site
  5. Click Shields icon and turn shields DOWN
  6. Visit brave://settings/shields and verified Disabled is selected to match to brave://settings/cookies
  7. Return to www.whatismybrowser.com to verify all cookies shown in the dev tools
  8. Verified www.whatismybrowser.com site entry is shown in the Sites that can always use cookies in brave://settings/cookies
  9. Verified www.whatismybrowser.com entry cannot be removed by clicking the trash icon - see Provide a user-friendly message OR hide icon in brave://settings/cookies when user clicks on trash-can icon for Allow all rule for site entry #24106
Step 3 Step 5 Step 6 Step 7 Step 8
3 5 6 7 8

Case 5: Set to Block all cookies in the Shields panel - PASSED

  1. Continue from Case 4:
    • Keep Allow all cookies in brave://settings/cookies
    • www.whatismybrowser.com site entry is still shown in the Sites that can always use cookies in brave://settings/cookies
  2. Visit www.whatismybrowser.com site
    • Click Shields icon and toggle ON for shields
    • Select Block all cookies in the Shields panel
  3. Visit brave://settings/shields and verify Disabled selected
  4. Return to www.whatismybrowser.com
  5. Clear cookies in dev tools and reload the site
  6. Verified no cookies shown in the dev tools
  7. Verified www.whatismybrowser.com site entry is shown in the Sites that can never use cookies in brave://settings/cookies
  8. Verified www.whatismybrowser.com site entry is removed in the Sites that can always use cookies in brave://settings/cookies
Step 1 Step 2 Step 3 Step 6 Step 7&8
1 2 3 6 7-8

Case 6: Set to Block cross-site cookies in Shields panel - PASSED

  1. Continue from Case 5:
    • Keep Allow all cookies in brave://settings/cookies
    • www.whatismybrowser.com site entry is still shown in the Sites that can never use cookies in brave://settings/cookies
  2. Visit www.whatismybrowser.com site
    • Select Block cross-site cookies in the Shields panel
  3. Open brave://settings/shields and verify Disabled is selected to match to brave://settings/cookies
  4. Reload www.whatismybrowser.com site
  5. Verified no 3rd party cookies shown in the dev tools
  6. Verified [*.]whatismybrowser.com entry is shown in Sites than can always use cookies in brave://settings/cookies
Step 1 Step 2 Step 3 Step 5 Step 6
1 2 3 5 6

Case 7: Remove first party rule in brave://settings/cookies - PASSED

  1. Continue from Case 6:
    • [*.]whatismybrowser.com entry is still listed in Sites than can always use cookies in brave://settings/cookies
    • Keep Allow all cookies in `brave://settings/cookies
    • www.whatismybrowser.com entry is still shown in the Sites that can never use cookies in brave://settings/cookies
    • delete all cookies in dev tools (see video from PR for instruction if needed)
  2. Click trash icon next to [*.]whatismybrowser.com to delete the entry in Sites that can always use cookies
  3. Return to www.whatismybrowser.com site and verify Shield settings changed to Block all cookies
  4. Clear cookies in dev tools and reload the site
  5. Verified no cookies shown in the dev tools
Step 1 Step 2 Step 3 Step 5
1 2 3 5

Case 8: Remove block rule in brave://settings/cookies - PASSED

  1. Continue from Case 7:
    • www.whatismybrowser.com entry is still listed in Sites that can never use cookies in brave://settings/cookies
    • Keep Allow all cookies in brave://settings/cookies
    • Shields panel shows Block all cookies setting
  2. Click trash icon next to www.whatismybrowser.com to delete the entry in Sites that can never use cookies
  3. Return to www.whatismybrowser.com site and verify Shield settings changed to Allow all cookies
  4. Reload the site
  5. Verified all cookies shown in the dev tools
Step 1a Step 1b Step 2 Step 3 Step 5
1a 1b 2 3 5

Case 9: Change to default setting, Block third-party cookies in brave://settings/cookies - PASSED

  1. Continue from Case 8:
    • Allow all cookies in brave://settings/cookies is already selected
  2. Select default setting of Block third-party cookies in brave://settings/cookies
  3. Return to www.whatismybrowser.com site and verify Shield settings changed to Block cross-site cookies
  4. Open brave://settings/shields and verified Only cross-site selected
  5. Return to www.whatismybrowser.com site
  6. Clear cookies in dev tools and reload the site
  7. Verified no 3rd party cookies shown in the dev tools
Step 1 Step 2 Step 3 Step 4 Step 7
1 2 3 4 7

Case 10: Manually add allow all rule in brave://settings/cookies - PASSED

  1. Continue from Case 9
    • Keep default setting of Block third-party cookies in brave://settings/cookies
    • Shields panel shows Block cross-site only setting
  2. Manually add www.whatismybrowser.com in Sites than can always use cookies in brave://settings/cookies
  3. Check the check box of Including third-party cookies on this site
  4. Return to www.whatismybrowser.com site and verify Shield settings changed to Allow all cookies
  5. Block third-party cookies setting is still retained brave://settings/cookies
  6. Clear cookies in dev tools and reload the site
  7. Verified all cookies shown in the dev tools including 3rd cookies
Step 1a Step 1b Step 3 Step 4 Step 5 Step 7
1a 1b 3 4 5 7

Case 11: Manually add allow all rule in brave://settings/cookies - do not check for 3rd party cookies - PASSED

  1. Continue from Case 10
  • Keep default setting of Block third-party cookies in brave://settings/cookies
  • Shields panel shows Block cross-site only setting
  1. Remove entry from TC 10, then manually add www.whatismybrowser.com in Sites than can always use cookies in brave://settings/cookies
  2. Do not Check the check box of Including third-party cookies on this site
  3. Return to www.whatismybrowser.com site and verify Shield settings changed to Allow all cookies
  4. Block third-party cookies setting is still retained brave://settings/cookies
  5. Clear cookies in dev tools and reload the site
  6. Verified 3rd party cookies not shown in the dev tools
Step 1 Step 2 & 3 Step 4 Step 5 Step 7
1 3 4 5 7

Case 12: Manually remove allow all and add block all in brave://settings/cookies - PASSED

  1. Continue from Case 11
    • Keep default setting of Block third-party cookies in brave://settings/cookies
    • www.whatismybrowser.com entry is still listed Sites than can always use cookies in brave://settings/cookies
    • Shields panel in whatismybrowser.com still shows Allow all cookies setting
  2. open brave://settings/cookies and remove the entry for the www.whatismybrowser.com from Sites than can always use cookies
  3. Add www.whatismybrowser.com in Sites that can never use cookies in brave://settings/cookies including checking the checkbox for 3rd party cookies
  4. Return to www.whatismybrowser.com site and verify Shield settings changed to Block all cookies
  5. Clear cookies in dev tools and reload the site
  6. Verified no cookies shown in the dev tools
Step 1a Step 1b Step 2 Step 3 Step 4 Step 6
1a 1b 2 3 4 6

Case 13: Disable Shields in the Shields panel - PASSED

  1. Continue from Case 12
    • Keep default setting of Block third-party cookies in brave://settings/cookies
    • www.whatismybrowser.com is still listed in Sites that can never use cookies in brave://settings/cookies
  2. Return to www.whatismybrowser.com site and turn shields DOWN in the Shields panel
  3. Verified www.whatismybrowser.com entry is added to Sites than can always use cookies in brave://settings/cookies
  4. When Allow all rule is added in Step 3 when Shields was disabled, 'www.whatismybrowser.com' is hidden in Sites that can never use cookies section
  5. Confirmed www.whatismybrowser.com entry cannot be deleted when clicked on delete icon
  6. Return to www.whatismybrowser.com site and clear cookies in dev tools and reload the site
  7. Verified all cookies shown in the dev tools
Step 1 Step 2 Step 3 & 4 Step 7
1 2 3-4 7

Case 14: Enable Shields in the Shields panel - PASSED

  1. Continue from Case 13
    • Keep default setting of Block third-party cookies in brave://settings/cookies
      -www.whatismybrowser.com is still hidden in Sites that can never use cookies in brave://settings/cookies
    • Shields DOWN for www.whatismybrowser.com site in the Shields panel
    • www.whatismybrowser.com entry is available Sites than can always use cookies in brave://settings/cookies
  2. Return to www.whatismybrowser.com site and enable Shields
  3. Block all cookies setting is retained in the Shields panel
  4. www.whatismybrowser.com entry is removed from Sites than can always use cookies in brave://settings/cookies
  5. www.whatismybrowser.com is shown in Sites that can never use cookies
  6. Clear cookies in dev tools and reload the site
  7. Verified no cookies shown in the dev tools
Step 1a Step 1b Step 2 & 3 Step 4 & 5 Step 7
1a 1b 3-4 4-5 7

Case 15: Change to Block cross-site cookies in the Shields panel - PASSED

  1. Continue from Case 14
    • Keep default setting of Block third-party cookies in brave://settings/cookies
    • www.whatismybrowser.com entry is shown in Sites that can never use cookies
  2. Return to www.whatismybrowser.com site and select Block cross-site cookies
  3. www.whatismybrowser.com entry is added to Sites than can always use cookies in brave://settings/cookies
  4. Clear cookies in dev tools and reload the site
  5. Verified no 3rd party cookies shown in the dev tools
Step 1 Step 2 Step 3 Step 5
1 2 3 5

Case 16: Remove shields rules in brave://settings/cookies - PASSED

  1. Continue from Case 15
    • Keep default setting of Block third-party cookies in brave://settings/cookies
    • www.whatismybrowser.com entry is shown in Sites that can never use cookies in brave://settings/cookies
    • www.whatismybrowser.com entry is shown in Sites than can always use cookies in brave://settings/cookies
    • Shields panel shows Block cross-site cookies for www.whatismybrowser.com
  2. Delete following in brave://settings/cookies
    • www.whatismybrowser.com entry is shown in Sites that can never use cookies
    • www.whatismybrowser.com entry is shown in Sites than can always use cookies
  3. Return to www.whatismybrowser.com and confirmed Shields panel shows Block cross-site cookies
  4. Clear cookies in dev tools and reload the site
  5. Verified no 3rd party cookies shown in the dev tools
Step 1A Step 1B Step 2 Step 3 Step 5
1a 1b 2 3 5

Case 17: Allow all cookies in brave://settings/cookies - PASSED

pre-req: clear all cookies in dev tools

  1. Select Allow all cookies in brave://settings/cookies
  2. Load www.whatismybrowser.com and click on the lock icon>>Cookies>>webbrowsertests.com (the one with the 3rd party cookie)>>Block>>Done
  3. Click Reload to reload the page
  4. Verified Shields panel shows Allow all cookies settings
  5. Confirmed webbrowsertests.com entry is added to Sites that can never use cookies
  6. Return to www.whatismybrowser.com site and reload the page
  7. Verified no 3rd party cookies shown in the dev tools
Step 1 Step 2 Step 3 Step 4 Step 5 Step 7
1 2 3 4 5 7

Case 18: Shields Down in the Shields panel - PASSED

pre-req: clear all cookies in dev tools

  1. Keep Allow all cookies in brave://settings/cookies
  2. Return to www.whatismybrowser.com site
  3. Toggle OFF the shields in the Shields panel
  4. Verified no 3rd party cookies shown in the dev tools
Step 1 Step 2 Step 4
1 2 4

Case 19: Delete 3p rule from brave://settings/cookies - PASSED

pre-req: clear all cookies in dev tools

  1. Continue from Case 17
    • Keep Allow all cookies in brave://settings/cookies
    • www.webbrowsertests.com entry is still shown to Sites that can never use cookies
  2. Open brave://settings/cookies and remove www.webbrowsertests.com entry by clicking ellipsis>>Remove
  3. Return to the www.whatismybrowser.com site and clear cookies in dev tools and reload
  4. Verified all cookies shown in the dev tools
Step 1 Step 2 Step 4
1 2 4

@rebron rebron mentioned this issue Jul 22, 2022
Closed
@LaurenWags LaurenWags mentioned this issue Jul 22, 2022
Closed
@btlechowski
Copy link

Verification passed on

Brave 1.42.78 Chromium: 103.0.5060.134 (Official Build) beta (64-bit)
Revision 8ec6fce403b3feb0869b0732eda8bd95011d333c-refs/branch-heads/5060@{#1262}
OS Ubuntu 18.04 LTS

Case 1: Set to Allow all cookies in brave://settings/cookies - PASSED

  1. Install 1.42.x
  2. Launch Brave
  3. Open brave://settings/cookies
  4. Select Allow all cookies
  5. Visit https://www.whatismybrowser.com
  6. Click Shields icon>>Advanced Controls
  7. Verified Allow all cookies is selected
  8. Open dev tools in the site to verify all cookies shown
  9. Visit brave://settings/shields and verify Disabled selected - settings matched to brave://settings/cookies page
  10. Open brave://settings/siteData and verify all cookies shown

image
image
image
image
image

Case 2: Set to Block Third-party cookies in brave://settings/cookies - PASSED

  1. Continue from case 1 and clear all cookies or do a new profile prior to doing the below steps
  2. Select Block Third-party cookies in brave://settings/cookies
  3. Visit https://www.whatismybrowser.com
  4. Verified Block cross-site cookies is selected in the Shields panel
  5. Visit brave://settings/shields and verify Only cross-site is selected
  6. Load https://www.whatismybrowser.com
  7. Verified no 3rd party cookies shown in the dev tools
  8. Verified no '3rd party cookies` shown in brave://settings/siteData

image
image
image
image
image

Case 3: Set to Block all cookies in brave://settings/cookies - PASSED

  1. Continue from Case 2 and clear all cookies or do a new profile prior to doing the below steps
  2. Select Block all cookies in brave://settings/cookies
  3. Visit https://www.whatismybrowser.com
  4. Click Shields icon>>Advanced Controls
  5. Verified Block all cookies is selected
  6. Visit brave://settings/shields and verify All is selected
  7. Return to https://www.whatismybrowser.com
  8. Clear cookies in dev tools and reload the site
  9. Verified no cookies shown in the dev tools
  10. Verified no cookies shown in brave://settings/siteData for the site

image
image
image
image
image

Case 4: Set to Allow all cookies then Shields DOWN - PASSED

  1. New profile
  2. Launch Brave
  3. Open brave://settings/cookies and select Allow all cookies
  4. Visit www.whatismybrowser.com site
  5. Click Shields icon and turn shields DOWN
  6. Visit brave://settings/shields and verified Disabled is selected to match to brave://settings/cookies
  7. Return to www.whatismybrowser.com to verify all cookies shown in the dev tools
  8. Verified www.whatismybrowser.com site entry is shown in the Sites that can always use cookies in brave://settings/cookies
  9. Verified www.whatismybrowser.com entry cannot be removed by clicking the trash icon - see Provide a user-friendly message OR hide icon in brave://settings/cookies when user clicks on trash-can icon for Allow all rule for site entry #24106

image
image
image
image

Case 5: Set to Block all cookies in the Shields panel - PASSED

  1. Continue from Case 4:
    • Keep Allow all cookies in brave://settings/cookies
    • www.whatismybrowser.com site entry is still shown in the Sites that can always use cookies in brave://settings/cookies
  2. Visit www.whatismybrowser.com site
    • Click Shields icon and toggle ON for shields
    • Select Block all cookies in the Shields panel
  3. Visit brave://settings/shields and verify Disabled selected
  4. Return to www.whatismybrowser.com
  5. Clear cookies in dev tools and reload the site
  6. Verified no cookies shown in the dev tools
  7. Verified www.whatismybrowser.com site entry is shown in the Sites that can never use cookies in brave://settings/cookies
  8. Verified www.whatismybrowser.com site entry is removed in the Sites that can always use cookies in brave://settings/cookies

image
image

Case 6: Set to Block cross-site cookies in Shields panel - PASSED

  1. Continue from Case 5:
    • Keep Allow all cookies in brave://settings/cookies
    • www.whatismybrowser.com site entry is still shown in the Sites that can never use cookies in brave://settings/cookies
  2. Visit www.whatismybrowser.com site
    • Select Block cross-site cookies in the Shields panel
  3. Open brave://settings/shields and verify Disabled is selected to match to brave://settings/cookies
  4. Reload www.whatismybrowser.com site
  5. Verified no 3rd party cookies shown in the dev tools
  6. Verified [*.]whatismybrowser.com entry is shown in Sites than can always use cookies in brave://settings/cookies

image
image
image
image
image

Case 7: Remove first party rule in brave://settings/cookies - PASSED

  1. Continue from Case 6:
    • [*.]whatismybrowser.com entry is still listed in Sites than can always use cookies in brave://settings/cookies
    • Keep Allow all cookies in `brave://settings/cookies
    • www.whatismybrowser.com entry is still shown in the Sites that can never use cookies in brave://settings/cookies
    • delete all cookies in dev tools (see video from PR for instruction if needed)
  2. Click trash icon next to [*.]whatismybrowser.com to delete the entry in Sites that can always use cookies
  3. Return to www.whatismybrowser.com site and verify Shield settings changed to Block all cookies
  4. Clear cookies in dev tools and reload the site
  5. Verified no cookies shown in the dev tools

image
image
image
image
image

Case 8: Remove block rule in brave://settings/cookies - PASSED

  1. Continue from Case 7:
    • www.whatismybrowser.com entry is still listed in Sites that can never use cookies in brave://settings/cookies
    • Keep Allow all cookies in brave://settings/cookies
    • Shields panel shows Block all cookies setting
  2. Click trash icon next to www.whatismybrowser.com to delete the entry in Sites that can never use cookies
  3. Return to www.whatismybrowser.com site and verify Shield settings changed to Allow all cookies
  4. Reload the site
  5. Verified all cookies shown in the dev tools

image
image
image
image
image
image

Case 9: Change to default setting, Block third-party cookies in brave://settings/cookies - PASSED

  1. Continue from Case 8:
    • Allow all cookies in brave://settings/cookies is already selected
  2. Select default setting of Block third-party cookies in brave://settings/cookies
  3. Return to www.whatismybrowser.com site and verify Shield settings changed to Block cross-site cookies
  4. Open brave://settings/shields and verified Only cross-site selected
  5. Return to www.whatismybrowser.com site
  6. Clear cookies in dev tools and reload the site
  7. Verified no 3rd party cookies shown in the dev tools

image
image
image
image
image

Case 10: Manually add allow all rule in brave://settings/cookies - PASSED

  1. Continue from Case 9
    • Keep default setting of Block third-party cookies in brave://settings/cookies
    • Shields panel shows Block cross-site only setting
  2. Manually add www.whatismybrowser.com in Sites than can always use cookies in brave://settings/cookies
  3. Check the check box of Including third-party cookies on this site
  4. Return to www.whatismybrowser.com site and verify Shield settings changed to Allow all cookies
  5. Block third-party cookies setting is still retained brave://settings/cookies
  6. Clear cookies in dev tools and reload the site
  7. Verified all cookies shown in the dev tools including 3rd cookies

image
image
image
image
image
image

Case 11: Manually add allow all rule in brave://settings/cookies - do not check for 3rd party cookies - PASSED

  1. Continue from Case 10
  • Keep default setting of Block third-party cookies in brave://settings/cookies
  • Shields panel shows Block cross-site only setting
  1. Remove entry from TC 10, then manually add www.whatismybrowser.com in Sites than can always use cookies in brave://settings/cookies
  2. Do not Check the check box of Including third-party cookies on this site
  3. Return to www.whatismybrowser.com site and verify Shield settings changed to Allow all cookies
  4. Block third-party cookies setting is still retained brave://settings/cookies
  5. Clear cookies in dev tools and reload the site
  6. Verified 3rd party cookies not shown in the dev tools

image
image
image
image
image

Case 12: Manually remove allow all and add block all in brave://settings/cookies - PASSED

  1. Continue from Case 11
    • Keep default setting of Block third-party cookies in brave://settings/cookies
    • www.whatismybrowser.com entry is still listed Sites than can always use cookies in brave://settings/cookies
    • Shields panel in whatismybrowser.com still shows Allow all cookies setting
  2. open brave://settings/cookies and remove the entry for the www.whatismybrowser.com from Sites than can always use cookies
  3. Add www.whatismybrowser.com in Sites that can never use cookies in brave://settings/cookies including checking the checkbox for 3rd party cookies
  4. Return to www.whatismybrowser.com site and verify Shield settings changed to Block all cookies
  5. Clear cookies in dev tools and reload the site
  6. Verified no cookies shown in the dev tools

image
image
image

Case 13: Disable Shields in the Shields panel - PASSED

  1. Continue from Case 12
    • Keep default setting of Block third-party cookies in brave://settings/cookies
    • www.whatismybrowser.com is still listed in Sites that can never use cookies in brave://settings/cookies
  2. Return to www.whatismybrowser.com site and turn shields DOWN in the Shields panel
  3. Verified www.whatismybrowser.com entry is added to Sites than can always use cookies in brave://settings/cookies
  4. When Allow all rule is added in Step 3 when Shields was disabled, 'www.whatismybrowser.com' is hidden in Sites that can never use cookies section
  5. Confirmed www.whatismybrowser.com entry cannot be deleted when clicked on delete icon
  6. Return to www.whatismybrowser.com site and clear cookies in dev tools and reload the site
  7. Verified all cookies shown in the dev tools

image
image
image

Case 14: Enable Shields in the Shields panel - PASSED

  1. Continue from Case 13
    • Keep default setting of Block third-party cookies in brave://settings/cookies
      -www.whatismybrowser.com is still hidden in Sites that can never use cookies in brave://settings/cookies
    • Shields DOWN for www.whatismybrowser.com site in the Shields panel
    • www.whatismybrowser.com entry is available Sites than can always use cookies in brave://settings/cookies
  2. Return to www.whatismybrowser.com site and enable Shields
  3. Block all cookies setting is retained in the Shields panel
  4. www.whatismybrowser.com entry is removed from Sites than can always use cookies in brave://settings/cookies
  5. www.whatismybrowser.com is shown in Sites that can never use cookies
  6. Clear cookies in dev tools and reload the site
  7. Verified no cookies shown in the dev tools

image
image
image
image
image

Case 15: Change to Block cross-site cookies in the Shields panel - PASSED

  1. Continue from Case 14
    • Keep default setting of Block third-party cookies in brave://settings/cookies
    • www.whatismybrowser.com entry is shown in Sites that can never use cookies
  2. Return to www.whatismybrowser.com site and select Block cross-site cookies
  3. www.whatismybrowser.com entry is added to Sites than can always use cookies in brave://settings/cookies
  4. Clear cookies in dev tools and reload the site
  5. Verified no 3rd party cookies shown in the dev tools

image
image
image
image

Case 16: Remove shields rules in brave://settings/cookies - PASSED

  1. Continue from Case 15
    • Keep default setting of Block third-party cookies in brave://settings/cookies
    • www.whatismybrowser.com entry is shown in Sites that can never use cookies in brave://settings/cookies
    • www.whatismybrowser.com entry is shown in Sites than can always use cookies in brave://settings/cookies
    • Shields panel shows Block cross-site cookies for www.whatismybrowser.com
  2. Delete following in brave://settings/cookies
    • www.whatismybrowser.com entry is shown in Sites that can never use cookies
    • www.whatismybrowser.com entry is shown in Sites than can always use cookies
  3. Return to www.whatismybrowser.com and confirmed Shields panel shows Block cross-site cookies
  4. Clear cookies in dev tools and reload the site
  5. Verified no 3rd party cookies shown in the dev tools

image
image
image

Case 17: Allow all cookies in brave://settings/cookies - PASSED

pre-req: clear all cookies in dev tools

  1. Select Allow all cookies in brave://settings/cookies
  2. Load www.whatismybrowser.com and click on the lock icon>>Cookies>>webbrowsertests.com (the one with the 3rd party cookie)>>Block>>Done
  3. Click Reload to reload the page
  4. Verified Shields panel shows Allow all cookies settings
  5. Confirmed webbrowsertests.com entry is added to Sites that can never use cookies
  6. Return to www.whatismybrowser.com site and reload the page
  7. Verified no 3rd party cookies shown in the dev tools

image
image
image

Case 18: Shields Down in the Shields panel - PASSED

pre-req: clear all cookies in dev tools

  1. Keep Allow all cookies in brave://settings/cookies
  2. Return to www.whatismybrowser.com site
  3. Toggle OFF the shields in the Shields panel
  4. Verified no 3rd party cookies shown in the dev tools

image
image

Case 19: Delete 3p rule from brave://settings/cookies - PASSED

pre-req: clear all cookies in dev tools

  1. Continue from Case 17
    • Keep Allow all cookies in brave://settings/cookies
    • www.webbrowsertests.com entry is still shown to Sites that can never use cookies
  2. Open brave://settings/cookies and remove www.webbrowsertests.com entry by clicking ellipsis>>Remove
  3. Return to the www.whatismybrowser.com site and clear cookies in dev tools and reload
  4. Verified all cookies shown in the dev tools

image
image
image

@btlechowski btlechowski mentioned this issue Jul 28, 2022
Closed
@LaurenWags LaurenWags mentioned this issue Aug 2, 2022
Closed
@urbenlegend
Copy link

urbenlegend commented Aug 3, 2022 •
edited
Loading

I am on 1.42.86 and clicking on the trash icon in the Sites that can always use cookies list still does nothing. Are we sure this has actually been fixed? I tested by disabling shields on GitHub.com and trying to delete via the trash can button.

@LaurenWags
Copy link
Member

@urbenlegend there are still cases where clicking on the trash icon does not work, see follow up issue #24106

cc @rebron

@Robio
Copy link

Robio commented Aug 11, 2022 •
edited
Loading

Running Brave 1.42.88 on macOS 12.5 — this issue has not been resolved for me. There are no circumstances under which clicking the trash icon in "Sites that can always use cookies" actually removes the site, shields up or down.

@Gelsamel
Copy link

Still experiencing this in 2024 with this version:

image

Is it not kind of inexcusable that this is an issue in a privacy/security focused browser????

@Robio
Copy link

Robio commented Jul 5, 2024

Is it not kind of inexcusable that this is an issue in a privacy/security focused browser????

A little bit, yeah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boocmp boocmp

Labels
feature/cookie-allow-list feature/cookies feature/shields The overall Shields feature in Brave. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.42.x - Release
Development

Successfully merging a pull request may close this issue.

Cookies brave/brave-core