Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Critical linking issue for BR #8229

Closed
mandar-brave opened this issue Feb 13, 2020 · 1 comment · Fixed by brave/brave-core#4625
Closed

Critical linking issue for BR #8229

mandar-brave opened this issue Feb 13, 2020 · 1 comment · Fixed by brave/brave-core#4625
Assignees
@NejcZdovc
Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/include
Milestone
1.3.x - Release H...

Comments

@mandar-brave
Copy link

mandar-brave commented Feb 13, 2020 •
edited by kjozwiak
Loading

Original Issue

The onboarding BR link is incorrect.
@NejcZdovc

QA Test Cases

  • Check the area's mentioned via Fixes TOS links brave-core#4625 and ensure that https://basicattentiontoken.org/user-terms-of-service is being used and NOT https://brave.com/terms-of-use.
@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Feb 13, 2020
@mandar-brave mandar-brave changed the title TOS link issue Critical linking issue for BR Feb 13, 2020
@rebron rebron added this to the 1.3.x - Release Hotfix 2 milestone Feb 13, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Feb 13, 2020
@NejcZdovc
Fixes TOS links
38ff7b7 
Resolves brave/brave-browser#8229
@NejcZdovc NejcZdovc mentioned this issue Feb 13, 2020
Merged
32 tasks
This was referenced Feb 13, 2020
Merged
Merged
Merged
@srirambv
Copy link
Contributor

srirambv commented Feb 18, 2020 •
edited by LaurenWags
Loading

Verification passed on

Brave 1.3.116 Chromium: 80.0.3987.106 (Official Build) (64-bit)
Revision f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS Linux
  • Verified clicking on ToS on rewards panel opens a new tab and navigates to https://basicattentiontoken.org/user-terms-of-service/
  • Verified ToS links on brave://rewards page links to https://basicattentiontoken.org/user-terms-of-service/ and opens in a new tab when clicked

Verification passed on

Brave 1.3.116 Chromium: 80.0.3987.106 (Official Build) (64-bit)
Revision f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified clicking on ToS on rewards panel opens a new tab and navigates to https://basicattentiontoken.org/user-terms-of-service/
  • Verified ToS links on brave://rewards page links to https://basicattentiontoken.org/user-terms-of-service/ and opens in a new tab when clicked
    image

Verified passed with

Brave 1.3.116 Chromium: 80.0.3987.106 (Official Build) (64-bit)
Revision f68069574609230cf9b635cd784cfb1bf81bb53a-refs/branch-heads/3987@{#882}
OS macOS Version 10.14.6 (Build 18G3020)
  • Verified clicking on ToS on rewards panel opens a new tab and navigates to https://basicattentiontoken.org/user-terms-of-service/
  • Verified that the ToS links on brave://rewards page link to https://basicattentiontoken.org/user-terms-of-service/ and open in a new tab when clicked

@kjozwiak kjozwiak mentioned this issue Feb 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release/blocking release-notes/include
Projects
None yet
Milestone
1.3.x - Release Hotfix 2
Development

Successfully merging a pull request may close this issue.

Fixes TOS links brave/brave-core
7 participants
@kjozwiak @rebron @NejcZdovc @srirambv @LaurenWags @mandar-brave @GeetaSarvadnya