Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide same list of Search Engines as browser-laptop with engine go key #731

Closed
srirambv opened this issue Aug 10, 2018 · 2 comments · Fixed by brave/brave-core#516
Closed

Provide same list of Search Engines as browser-laptop with engine go key #731

srirambv opened this issue Aug 10, 2018 · 2 comments · Fixed by brave/brave-core#516
Assignees
@mkarolin
Labels
browser-laptop-parity feature/search QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
0.55.x - Release ...

Comments

@srirambv
Copy link
Contributor

srirambv commented Aug 10, 2018 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#516

Description

Provide same list of Search Engines as browser-laptop with engine go key

Actual result:

image

Expected result:

Same list but probably without : in Engine go key
image
@srirambv srirambv added this to the Backlog milestone Aug 10, 2018
@srirambv srirambv mentioned this issue Aug 10, 2018
Closed
7 tasks
@eljuno
Copy link

eljuno commented Sep 28, 2018

+1 from community https://community.brave.com/t/features-search-engine-go-keys-missing-colored-tabs-bookmarks-bar/33485?u=eljuno

@eljuno eljuno mentioned this issue Sep 28, 2018
Closed
@mkarolin mkarolin mentioned this issue Sep 28, 2018
Merged
11 tasks
@bsclifton bsclifton modified the milestones: 1.x Backlog, Releasable builds 0.55.x Sep 28, 2018
@bsclifton bsclifton mentioned this issue Sep 28, 2018
Closed
mkarolin added a commit to brave/brave-core that referenced this issue Oct 1, 2018
@mkarolin
Fixes brave/brave-browser#893
a95c3c3 
Fixes brave/brave-browser#731

Overrode Chromium's set of prepopulated search engines with our own set and regional defaults.
Added new unit tests to:
 * check for duplicate prepopulate ids and keywords
 * check for correct default search engine based on locale
 * check that prepopulated engines have all required fields
@srirambv
Copy link
Contributor Author

srirambv commented Oct 5, 2018 •
edited by GeetaSarvadnya
Loading

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux
  • Verified all scenarios mentioned in test plan and works great

Verified passed with

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta(64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Mac OS X
  • Verified all scenarios from test plan 👍

Verification Passed with

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Windows
  • Verified all scenarios from test plan 👍

@kjozwiak kjozwiak mentioned this issue Nov 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
browser-laptop-parity feature/search QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Default search engines by region brave/brave-core
6 participants
@bsclifton @srirambv @eljuno @LaurenWags @GeetaSarvadnya @mkarolin