Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a switch to disable Brave Wallet #5673

Closed
bbondy opened this issue Aug 15, 2019 · 5 comments · Fixed by brave/brave-core#3208
Closed

Add a switch to disable Brave Wallet #5673

bbondy opened this issue Aug 15, 2019 · 5 comments · Fixed by brave/brave-core#3208

Comments

@bbondy
Copy link
Member

bbondy commented Aug 15, 2019

Add a switch in preferences alongside the IPFS and WebTorrent one to disable Brave Wallet functionality. This will prevent it from being loaded and even installed if one navigates to brave://wallet.

If you disable it should not show the option in the hamburger menu for the wallet. It should also fail to load if you go direct to brave://wallet, it should say blocked.

There's a distinction that's important to understand between enabled and installed.

By default Brave rewards is enabled (and can be installed implicitly by selecting the menu item or by navigating to brave://wallet). If you do a new profile and go directly to settings, you'll see it enabled, because the functionality is available.
You can disable right away on a new profile, in which case the hamburger menu won't be available and requests will be blocked.

@kjozwiak
Copy link
Member

kjozwiak commented Oct 4, 2019

@bbondy @ryanml is this the same as the switch that's currently available in the 0.69.x release via brave://settings? Example:

Screen Shot 2019-10-03 at 9 23 05 PM

When enabling/disabling the above, it will remove Crypto Wallets from the hamburger menu but won't remove the header button via brave://settings.

If this is different, can we get a test plan? Thanks!

@PaulRBerg
Copy link

A suggestion for MetaMask users: automatically set "Crypto Wallet" to false. I was debugging my dapp and I thought there was a problem with my code but there were just too many web3 providers.

@kjozwiak
Copy link
Member

kjozwiak commented Oct 7, 2019

@PaulRBerg we're discussing how to handle the above better when MM is also installed. CCing @tomlowenthal.

@LaurenWags
Copy link
Member

QA/Blocked pending response to #5673 (comment)

@kjozwiak
Copy link
Member

kjozwiak commented Oct 15, 2019

Talked to @bbondy re: the above. This already landed in 0.69.x as per #5673 (comment). It was also QA'd extensively in other ETH related issues in 0.69.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment