Different theme choice in different profiles affects other profiles #5373

petemill · 2019-07-24T18:28:01Z

When having multiple profiles, if profile A changes the preference for Theme, profile B is affected.

Test plan / Steps to Reproduce

Open Settings page in current profile window (Profile A)
Set Theme to Light
Open profile B window
--> Observe Profile A and Profile B have same theme (light or dark)
Open Settings page in both Profile A window and Profile B window
Change theme selection in Profile B to Dark

Expected

Profile B change to Dark. Profile A stays light - both the browser toolbar, and the Settings page background.

Actual

Profile B and Profile A both change to Dark - both the browser toolbar and the Settings page background.

simonhong · 2019-07-24T22:48:45Z

Yes, I think this is the limitation of current chromium architecture because dark mode is managed in ui layer and there is no profile concept in that layer.

petemill · 2019-07-24T22:52:13Z

@simonhong edge canary 77.0.228.0 (based on chromium) has the same issue!

simonhong · 2019-07-24T22:56:47Z

right, I saw that. Need to think how to overcome :)

LaurenWags · 2019-10-03T17:15:48Z

Other ways to reproduce
From @petemill using Mojave:
(pre-req: have multiple profiles):

macOS is set to dark
Change Brave to 'Light'
Restart browser
Dialogs, webui and infobars are dark, but toolbar is light

From me using High Sierra:

Clean profile on Nightly (0.72.68), Nightly defaults to dark.
Create a new profile so you now have two
Go to brave://settings on second profile
Change Brave colors to Light
Second profile window appears light (settings page, toolbar, hamburger menu, etc.

First profile is now in an in-between state. Toolbar is dark, but hamburger menu and settings page are light.

Restart Nightly.
First profile window is now as expected (toolbar, settings page, hamburger menu, etc) are dark.

Second profile window is now in an in-between state - Toolbar is light, but settings page and hamburger menu are dark.

This flip flop about which profile is in which state (inbetween or expected) will continue - it looks like maybe related to which profile you had active when closing the browser.

bsclifton · 2019-11-05T04:46:54Z

@simonhong were you still checking this and #5557 out? (if not, maybe you can un-assign yourself. Thanks! 😄)

simonhong · 2019-12-09T04:31:42Z

@rebron @bsclifton @petemill Brave theme inconsistency can happen easily when a user uses multi profiles.
How about making brave theme option to browser wide prefs? It means migrating theme prefs from profile to local state.
I think it's the easiest solution for use and assume that edge might have same policy.
WDYT?

petemill · 2019-12-09T06:44:22Z

Yes I agree @simonhong. It's not possible to align native theme properly otherwise.

bsclifton · 2019-12-09T06:44:28Z

@simonhong I like that approach 😄

LaurenWags · 2019-12-09T14:33:16Z

++ on @simonhong suggestion

simonhong · 2019-12-10T00:21:00Z

Thanks for feedback @LaurenWags @bsclifton @petemill :)
I'll start this :)

LaurenWags · 2019-12-10T00:22:58Z

something we should consider when checking upgrade cases - if a user is currently in a position where one or more profiles have different themes set, which one gets globally set on upgrade? I'd probably vote the theme on the Default profile, but unsure if there are other things to consider here?

simonhong · 2019-12-10T00:27:15Z

@LaurenWags Migrating theme option from profile to local state(global pref) will be done only once.
When it happens, I think options from firstly activated profile would be used for migration.
After that, it becomes the global option.
Actually, determining which profile is default or not is difficult. WDYT?

LaurenWags · 2019-12-10T00:32:28Z

As long it's documented which one we should expect I'm good with whatever 😄 thanks @simonhong!

simonhong · 2019-12-10T00:35:01Z

I used same policy for migrating Widevine prefs.
Widevine had similar issue. (#6747)
If user think migrated theme is not his/her default theme option, just need one time option changing :)

With this, we can fix brave theme related bugs with multi profile because all profiles use browser-wide prefs. So far, system theme could be changed whenever new profile is used because brave theme was profile prefs but system theme is browser wide setting. And did cleanup and refactoring. Refactoring point is separation of theme managing and dark mode managing. So far, theme service has all dark mode handling logic. But I think theme service handles browser theme with underrlying dark mode. So, all dark mode logic is in dark_mode namespace. fix brave/brave-browser#5373 fix brave/brave-browser#5557

GeetaSarvadnya · 2020-02-13T10:34:01Z

Verification passed on

Brave	1.4.84 Chromium: 80.0.3987.87 (Official Build) beta (64-bit)
Revision	449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

Verified the test plan from Migrated brave theme prefs from profile to local state brave-core#4210
Verified that theme change in one Profile affects all other profiles
Have 3 profiles P1, P2 and P3 in 1.3.x and set different themes in each profile and upgrade to 1.4.x
after the upgrade ensured that all three profiles have the same theme.
Verified that based on theme selection, toolbar and settings and hamburger menu items changed in all the profiles

Dark Theme:

Light Theme

Same as windows

Verification passed on

Brave	1.4.93 Chromium: 80.0.3987.116 (Official Build) (64-bit)
Revision	dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917}
OS	Linux

Verified the test plan from Migrated brave theme prefs from profile to local state brave-core#4210
Verified that theme change in one Profile affects all other profiles
Have 2 profiles P1 and P2 in 1.3.x and set different themes in each profile and upgrade to 1.4.x
after the upgrade ensured that both profiles have the same theme.
Verified that based on theme selection, toolbar and settings and hamburger menu items changed in all the profiles

Light theme

Dark theme

Verification PASSED on macOS 10.15.3 x64 using the following build:

Brave	1.4.93 Chromium: 80.0.3987.116 (Official Build) (64-bit)
Revision	dc00a510e4c2ae25c4d084cc3d946fc782249224-refs/branch-heads/3987@{#917}
OS	macOS Version 10.15.3 (Build 19D76)

Verified the test plan from Migrated brave theme prefs from profile to local state brave-core#4210
Verified that theme change in one Profile affects all other profiles
Have 2 profiles P1 and P2 in 1.3.x and set different themes in each profile and upgrade to 1.4.x
after the upgrade ensured that both profiles have the same theme.
Verified that based on theme selection, toolbar and settings and hamburger menu items changed in all the profiles

drzamich · 2021-02-21T17:38:55Z

It would actually be nice for Brave to support different theming in different profiles. I like to separate work and private browsing. When having different themes in profiles, I can immediately know which profile I'm on so that I don't accidentally share my browsing history when on screen sharing for instance.

petemill assigned simonhong Jul 24, 2019

kjozwiak added bug feature/profile-manager feature/settings QA/Test-Plan-Specified QA/Yes labels Jul 24, 2019

petemill added feature/themes and removed feature/profile-manager labels Jul 24, 2019

petemill unassigned simonhong Jul 24, 2019

simonhong mentioned this issue Aug 7, 2019

Open profile manager causes entire browser UI to go dark #5557

Closed

simonhong self-assigned this Aug 7, 2019

rebron added the priority/P4 Planned work. We expect to get to it "soon". label Aug 9, 2019

kjozwiak mentioned this issue Oct 8, 2019

Partial theme switch when opening new profile #6341

Closed

simonhong added this to the 1.4.x - Nightly milestone Dec 10, 2019

simonhong mentioned this issue Dec 11, 2019

Migrated brave theme prefs from profile to local state brave/brave-core#4210

Merged

32 tasks

bsclifton closed this as completed in brave/brave-core#4210 Dec 18, 2019

bsclifton added the release-notes/include label Dec 18, 2019

GeetaSarvadnya added the QA Pass-Win64 label Feb 13, 2020

GeetaSarvadnya added the QA Pass-Linux label Feb 20, 2020

kjozwiak added the QA Pass-macOS label Feb 21, 2020

kjozwiak mentioned this issue Feb 25, 2020

Release Notes for 1.4.x (Release Channel) #8395

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Different theme choice in different profiles affects other profiles #5373

Different theme choice in different profiles affects other profiles #5373

petemill commented Jul 24, 2019 •

edited by bsclifton

Loading

simonhong commented Jul 24, 2019 •

edited

Loading

petemill commented Jul 24, 2019

simonhong commented Jul 24, 2019 •

edited

Loading

LaurenWags commented Oct 3, 2019

bsclifton commented Nov 5, 2019 •

edited

Loading

simonhong commented Dec 9, 2019 •

edited

Loading

petemill commented Dec 9, 2019

bsclifton commented Dec 9, 2019

LaurenWags commented Dec 9, 2019

simonhong commented Dec 10, 2019

LaurenWags commented Dec 10, 2019

simonhong commented Dec 10, 2019 •

edited

Loading

LaurenWags commented Dec 10, 2019

simonhong commented Dec 10, 2019

GeetaSarvadnya commented Feb 13, 2020 •

edited by kjozwiak

Loading

drzamich commented Feb 21, 2021

Different theme choice in different profiles affects other profiles #5373

Different theme choice in different profiles affects other profiles #5373

Comments

petemill commented Jul 24, 2019 • edited by bsclifton Loading

Test plan / Steps to Reproduce

Expected

Actual

simonhong commented Jul 24, 2019 • edited Loading

petemill commented Jul 24, 2019

simonhong commented Jul 24, 2019 • edited Loading

LaurenWags commented Oct 3, 2019

bsclifton commented Nov 5, 2019 • edited Loading

simonhong commented Dec 9, 2019 • edited Loading

petemill commented Dec 9, 2019

bsclifton commented Dec 9, 2019

LaurenWags commented Dec 9, 2019

simonhong commented Dec 10, 2019

LaurenWags commented Dec 10, 2019

simonhong commented Dec 10, 2019 • edited Loading

LaurenWags commented Dec 10, 2019

simonhong commented Dec 10, 2019

GeetaSarvadnya commented Feb 13, 2020 • edited by kjozwiak Loading

drzamich commented Feb 21, 2021

petemill commented Jul 24, 2019 •

edited by bsclifton

Loading

simonhong commented Jul 24, 2019 •

edited

Loading

simonhong commented Jul 24, 2019 •

edited

Loading

bsclifton commented Nov 5, 2019 •

edited

Loading

simonhong commented Dec 9, 2019 •

edited

Loading

simonhong commented Dec 10, 2019 •

edited

Loading

GeetaSarvadnya commented Feb 13, 2020 •

edited by kjozwiak

Loading