Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media_router::DialServiceImpl should not initiate UPnP connections by default #5070

Closed
jumde opened this issue Jun 28, 2019 · 1 comment · Fixed by brave/brave-core#2836
Closed

media_router::DialServiceImpl should not initiate UPnP connections by default #5070

jumde opened this issue Jun 28, 2019 · 1 comment · Fixed by brave/brave-core#2836
Assignees
@jumde
Labels
priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
0.66.x - Release ...

Comments

@jumde
Copy link
Contributor

jumde commented Jun 28, 2019 •
edited
Loading

Test Plan

specified here: brave/brave-core#2836
@jumde jumde added the privacy label Jun 28, 2019
@jumde jumde self-assigned this Jun 28, 2019
@tildelowengrimm tildelowengrimm mentioned this issue Jun 29, 2019
Closed
@tildelowengrimm tildelowengrimm added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 29, 2019
@jumde jumde mentioned this issue Jul 1, 2019
Merged
32 tasks
@jumde jumde added this to the 0.69.x - Nightly milestone Jul 3, 2019
This was referenced Jul 9, 2019
Merged
Merged
Merged
This was referenced Jul 16, 2019
Closed
Closed
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Jul 16, 2019 •
edited by GeetaSarvadnya
Loading

Verification PASSED on macOS 10.14.5 x64 using the following build:

Brave 0.66.100 Chromium: 75.0.3770.142 (Official Build) (64-bit)
Revision 8d93477bd18154c67a70a67019cb8032382c55dd-refs/branch-heads/3770@{#1160}
OS Mac OS X

Screen Shot 2019-07-16 at 12 18 38 PM

Verification passed on

Brave 0.66.100 Chromium: 75.0.3770.142 (Official Build) (64-bit)
Revision 8d93477bd18154c67a70a67019cb8032382c55dd-refs/branch-heads/3770@{#1160}
OS Windows 7 Service Pack 1 (Build 7601.24494)

Used test plan from brave/brave-core#2836
When Enabled SSDP:
image

Verification passed on

Brave 0.66.100 Chromium: 75.0.3770.142 (Official Build) (64-bit)
Revision 8d93477bd18154c67a70a67019cb8032382c55dd-refs/branch-heads/3770@{#1160}
OS Ubuntu 18.04 LTS

Used test plan from brave/brave-core#2836
When Enabled SSDP:
image

Verification passed on

Brave 0.66.100 Chromium: 75.0.3770.142 (Official Build) (64-bit)
Revision 8d93477bd18154c67a70a67019cb8032382c55dd-refs/branch-heads/3770@{#1160}
OS Windows 10 OS Version 1803 (Build 17134.523)

@kjozwiak kjozwiak mentioned this issue Jul 16, 2019
Closed
@rebron rebron changed the title media_router::DialServiceImpl should not initiate UpNP connections by default media_router::DialServiceImpl should not initiate UPnP connections by default Jul 16, 2019
tmancey pushed a commit that referenced this issue Apr 9, 2020
@kjozwiak
Merge pull request #5070 from brave/pr4978_issue_4646_widevine_1.7.x
19548e8 
Reload active tab when widevine library is ready to use (uplift to 1.7.x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jumde jumde

Labels
priority/P3 The next thing for us to work on. It'll ride the trains. privacy QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
0.66.x - Release Hotfix 1 (Release Ch...
5 participants
@tildelowengrimm @jumde @kjozwiak @bsclifton @btlechowski