Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about:adblock page with custom filter selection followup to #267 #403

Closed
srirambv opened this issue Jun 22, 2018 · 9 comments · Fixed by brave/brave-core#1966
Closed

about:adblock page with custom filter selection followup to #267 #403

srirambv opened this issue Jun 22, 2018 · 9 comments · Fixed by brave/brave-core#1966
Assignees
Labels
feature/brave-pages feature/shields/adblock Blocking ads & trackers with Shields feature/shields The overall Shields feature in Brave. priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

srirambv commented Jun 22, 2018

Description

Create an about:adblock page followup to #267. Add a custom block filter section similar to muon build
image

Additional information

#267
See also #1931

@bsclifton
Copy link
Member

Per brave/browser-laptop#9711, the user should be able to specify a remote URL as the filter (instead of only adding entries themselves)

@srirambv srirambv added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 29, 2018
@bbondy bbondy added the feature/shields The overall Shields feature in Brave. label Oct 31, 2018
@bbondy bbondy changed the title Create an about:adblock page with regional and custom filter followup to #267 about:adblock page with custom filter selection followup to #267 Oct 31, 2018
@tildelowengrimm tildelowengrimm added priority/P5 Not scheduled. Don't anticipate work on this any time soon. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Oct 31, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@eljuno
Copy link

eljuno commented Feb 27, 2019

@tawissus
Copy link

Will it be available too in Brave for Android?

@srirambv srirambv added this to the 0.64.x - Release milestone May 8, 2019
@srirambv
Copy link
Contributor Author

srirambv commented May 8, 2019

Adding the issue to 0.64.x as its a follow up to #403

Verification passed on

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Linux

Verified passed with

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Verification passed on

Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

@bridiver
Copy link
Contributor

I don't think these settings were meant to be global, were they? I don't think that makes sense.

@bsclifton
Copy link
Member

@bridiver what do you mean? Are these supposed to be applied on a per-site basis?

@sys9kdr
Copy link

sys9kdr commented Jun 23, 2019

Looks good. But I can't add remote URL as the filter #403 (comment) yet. Should I open a new issue about external filter support?

Per brave/browser-laptop#9711, the user should be able to specify a remote URL as the filter (instead of only adding entries themselves)

@bsclifton
Copy link
Member

@sys9kdr please do

@ggiacomoo
Copy link

i'm on windows and updated,
i've copy/pasted rule from chrome's adBlock, to brave chrome://adblock/ Custom Filters
but it's doesn't works, where i'm wrong!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/brave-pages feature/shields/adblock Blocking ads & trackers with Shields feature/shields The overall Shields feature in Brave. priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.